Page MenuHomeFreeBSD

arm64: Fix a use of update_lower_register
ClosedPublic

Authored by andrew on Jul 3 2023, 11:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 19, 11:40 AM
Unknown Object (File)
Wed, Sep 18, 5:15 PM
Unknown Object (File)
Wed, Sep 18, 4:44 PM
Unknown Object (File)
Fri, Sep 6, 1:19 AM
Unknown Object (File)
Aug 3 2024, 12:11 AM
Unknown Object (File)
Jul 6 2024, 4:20 PM
Unknown Object (File)
Jun 8 2024, 3:17 PM
Unknown Object (File)
May 1 2024, 7:02 AM

Details

Summary

In get_kernel_reg_masked we use update_lower_register to get the lower
value of two registers for a given field. It will return the entire
register value with just the single field updated.

Because of this get_kernel_reg_masked needs to use the returned value
directly rather than ORing each field together. Fix this by updating
the mask and returning that from get_kernel_reg_masked.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 4 2023, 2:38 PM
christos added inline comments.
sys/arm64/arm64/identcpu.c
1829

Did you mean valp instead?

This revision was automatically updated to reflect the committed changes.