setclasspriority(): New value 'inherit'

[olce]

Summary

It indicates to the login.conf machinery (setusercontext()/setclasscontext()) to
leave priority alone, effectively inheriting it from the parent process.

[yuripv]

lib/libutil/login_class.c

468

why do you need to use the ret variable at all, and not just compare the return value of login_getcapenum() here?

[olce]

Remove ret variable, call login_capgetenum() in the test directly

This is a leftover of a time I had envisioned to log selective messages
depending on the error, but in the end I don't think it would be particularly
useful. Lots of other calls into login_class(3) or login_cap(3) can fail in
"unexpected" ways (out of memory, programming error) and this is not currently
treated specially. These are bugs (and even potentially security ones) that
should be solved as separate work. login_capgetenum() is nor better nor worse
in this respect.

[olce]

Refresh

[emaste]

lib/libutil/login_class.c

469–470

Personally I would either put braces around the block, or move the comment before the if (e.g. /* Do nothing if the priority is "inherit". */)

Even though it's still only a single statement I think the braces improve clarity when it's more than one line.

[olce]

Address suggestions (move a comment out of an if).