Page MenuHomeFreeBSD

setlogincontext(): Comply to style(9)
ClosedPublic

Authored by olce on May 31 2023, 2:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 28 2024, 8:36 PM
Unknown Object (File)
Sep 27 2024, 1:08 PM
Unknown Object (File)
Sep 26 2024, 5:54 AM
Unknown Object (File)
Sep 26 2024, 5:54 AM
Unknown Object (File)
Sep 26 2024, 5:54 AM
Unknown Object (File)
Sep 25 2024, 9:01 PM
Unknown Object (File)
Sep 25 2024, 4:40 PM
Unknown Object (File)
Sep 25 2024, 9:22 AM

Details

Summary

Remove indentation by inverting the big 'if (lc)' and using 'return'.
Use explicit binary operators to produce booleans.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.May 31 2023, 2:34 PM

Update the diff following update of D40344. Same final result.

dchagin added inline comments.
lib/libutil/login_class.c
432–433

if ((flags & LOGIN_SETUMASK) != 0) {

and below

olce retitled this revision from setlogincontext(): Re-format to comply to style(9) to setlogincontext(): Comply to style(9).
olce edited the summary of this revision. (Show Details)

Explicit booleans in tests.

olce marked an inline comment as done.Jun 15 2023, 2:03 PM
olce added inline comments.
lib/libutil/login_class.c
432–433

And above as well. Thanks.

olce marked an inline comment as done.Jun 15 2023, 2:49 PM
lib/libutil/login_class.c
447

There should be a blank line between locals block and first statement.

460

Same

olce marked 2 inline comments as done.Jun 21 2023, 1:41 PM
This revision is now accepted and ready to land.Jan 26 2024, 2:31 PM
This revision was automatically updated to reflect the committed changes.