Page MenuHomeFreeBSD

bhyve: add execution command for tpm devices
ClosedPublic

Authored by corvink on Jun 7 2023, 12:07 PM.
Tags
None
Referenced Files
F102557056: D40460.diff
Thu, Nov 14, 12:55 AM
Unknown Object (File)
Mon, Oct 21, 5:36 PM
Unknown Object (File)
Oct 4 2024, 9:36 PM
Unknown Object (File)
Sep 27 2024, 2:08 PM
Unknown Object (File)
Sep 22 2024, 8:09 PM
Unknown Object (File)
Sep 17 2024, 12:15 AM
Unknown Object (File)
Sep 12 2024, 2:19 AM
Unknown Object (File)
Sep 6 2024, 9:40 PM
Subscribers

Details

Summary

Executing a tpm command is as easy as writing the command to the tpm fd and reading back the result.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 51952
Build 48843: arc lint + arc unit

Event Timeline

usr.sbin/bhyve/tpm_emul_passthru.c
71

Should you check rsp_size >= sizeof(struct tpm_resp_hdr) before doing anything?

74

rsp_size is unsigned, the last format should be %u. I'm surprised the compiler doesn't warn about it.

markj added inline comments.
usr.sbin/bhyve/tpm_emul_passthru.c
71
78
This revision is now accepted and ready to land.Jun 23 2023, 2:58 PM