Page MenuHomeFreeBSD

bhyve/tpm: create crb thread for sending tpm commands
ClosedPublic

Authored by corvink on Jun 7 2023, 12:05 PM.
Tags
None
Referenced Files
F102556337: D40458.diff
Thu, Nov 14, 12:40 AM
Unknown Object (File)
Tue, Nov 5, 2:41 PM
Unknown Object (File)
Tue, Oct 22, 1:28 PM
Unknown Object (File)
Wed, Oct 16, 9:51 PM
Unknown Object (File)
Oct 9 2024, 5:02 PM
Unknown Object (File)
Oct 5 2024, 2:08 AM
Unknown Object (File)
Oct 4 2024, 10:43 PM
Unknown Object (File)
Oct 4 2024, 9:28 PM
Subscribers

Details

Summary

Commands send to a tpm are very slow. They can take up to several
seconds for completion. For that reason, create a thread which issues
the commands to the tpm device.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/bhyve/tpm_intf_crb.c
214
296

The mutex and condvar don't get destroyed anywhere.

310

Why not just write pthread_set_name_np(crb->thread, "tpm_intf_crb");?

331

Don't you need to wake up the thread here?

  • destroy cond and mutex
  • wakeup thread on destroy
markj added inline comments.
usr.sbin/bhyve/tpm_intf_crb.c
292

warn/warnx/warc/err/errx/errc always append a newline.

292

pthread_* returns an error number upon failure, so you can get a better error message with warnc(error, "%s: failed to init mutex", __func__);. Same below.

This revision is now accepted and ready to land.Jun 19 2023, 7:36 PM