avx_sig: Rename to more general name
ClosedPublic
Actions

Authored by dchagin on Jun 1 2023, 8:45 PM.

Details

Reviewers

jhb
kib

Commits

rG8fdc9ce97c00: avx_sig: Better naming as the test will include more register banks

Summary

Better naming as the test will include more register banks to test.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Jun 1 2023, 8:45 PM

Herald added subscribers: emaste, andrew, imp. · View Herald TranscriptJun 1 2023, 8:45 PM

dchagin requested review of this revision.Jun 1 2023, 8:45 PM

Harbormaster completed remote builds in B51845: Diff 122730.Jun 1 2023, 8:46 PM

dchagin retitled this revision from avx_sig: Rename to more general name Naming is hard (c) to avx_sig: Rename to more general name.Jun 1 2023, 8:51 PM

dchagin added reviewers: jhb, kib.

kib accepted this revision.Jun 1 2023, 10:45 PM

This revision is now accepted and ready to land.Jun 1 2023, 10:45 PM

Not quite sure what the "via" part means as normally I'd take that to mean that "xregs" were being delivered or provided by "sig" and I think this test is more about the fact that signal context properly saves/restores "xregs"? Maybe consider dropping "via"?

Closed by commit rG8fdc9ce97c00: avx_sig: Better naming as the test will include more register banks (authored by dchagin). · Explain WhyJun 3 2023, 5:13 PM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rG8fdc9ce97c00: avx_sig: Better naming as the test will include more register banks.