Page MenuHomeFreeBSD
Differential D40178

libthr rtld locks: do not leak URWLOCK_READ_WAITERS into child
ClosedPublic
Actions

Authored by kib on May 20 2023, 8:28 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 3, 5:15 PM
Unknown Object (File)
Wed, Oct 23, 6:08 AM
Unknown Object (File)
Tue, Oct 22, 10:35 PM
Unknown Object (File)
Mon, Oct 21, 8:45 PM
Unknown Object (File)
Sun, Oct 20, 9:39 PM
Unknown Object (File)
Sun, Oct 20, 9:33 PM
Unknown Object (File)
Sun, Oct 20, 9:33 PM
Unknown Object (File)
Sun, Oct 20, 9:33 PM
View All 92 Files
Subscribers
emaste
imp

Details

Reviewers
markj
Commits
rG6f49eafb056c: libthr rtld locks: do not leak URWLOCK_READ_WAITERS into child
Summary
Since there is only the current thread in the child, no pending readers
exist.  Clear the bit, since it confuses future attempts to acquire
write ownership of the rtld locks, due to URWLOCK_PREFER_READERS flag.

PR:     271490

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.May 20 2023, 8:28 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 20 2023, 8:28 AM
kib requested review of this revision.May 20 2023, 8:28 AM
kib updated this revision to Diff 122152.May 20 2023, 10:32 AM
kib added a reviewer: markj.

To be future-proof, clear all state about pending writers and readers.

emaste added a subscriber: emaste.May 20 2023, 1:26 PM
markj accepted this revision.May 22 2023, 1:32 PM

It would be nice to turn the test case from PR 271490 into a regression test case, either in the base system or in stress2.

lib/libthr/thread/thr_rtld.c
161

Perhaps use __predict_false here.

This revision is now accepted and ready to land.May 22 2023, 1:32 PM
Closed by commit rG6f49eafb056c: libthr rtld locks: do not leak URWLOCK_READ_WAITERS into child (authored by kib). · Explain WhyMay 22 2023, 1:47 PM
This revision was automatically updated to reflect the committed changes.
kib added a commit: rG6f49eafb056c: libthr rtld locks: do not leak URWLOCK_READ_WAITERS into child.

Revision Contents
Changeset List

PathSize
lib/
libthr/
thread/
4 lines
2 lines
11 lines

Diff 122215

View Options

lib/libthr/thread/thr_fork.c

Loading...
View Options

lib/libthr/thread/thr_private.h

Loading...
View Options

lib/libthr/thread/thr_rtld.c

Loading...