Tags

None

Referenced Files

	F96216446: D39125.diff
	Tue, Sep 24, 2:31 AM

	F96065213: D39125.id.diff
	Mon, Sep 23, 1:34 PM

	Unknown Object (File)
	Fri, Sep 20, 1:35 PM

	Unknown Object (File)
	Sun, Sep 15, 7:24 PM

	Unknown Object (File)
	Sun, Sep 8, 1:23 PM

	Unknown Object (File)
	Sun, Sep 8, 12:00 AM

	Unknown Object (File)
	Thu, Aug 29, 7:16 AM

	Unknown Object (File)
	Aug 21 2024, 3:15 PM

View All 50 Files

Subscribers

imp

Contributor Reviews (src)

Details

Reviewers

markj
asomers

Group Reviewers

network

Commits

rG3c7ef29e8998: ping: Avoid magic numbers
rG491263d7a640: ping: Avoid magic numbers

Summary

The sizeof(struct ip) is 20.
The sizeof(struct in_addr) is 4.
No functional change intended.

Test Plan

kyua test -k /usr/tests/Kyuafile sbin/ping/ping_test
kyua test -k /usr/tests/Kyuafile sbin/ping/test_ping.py

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

jlduran_gmail.com created this revision.Mar 16 2023, 4:35 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 16 2023, 4:35 PM

jlduran_gmail.com requested review of this revision.Mar 16 2023, 4:35 PM

jlduran_gmail.com added a child revision: D38469: ping: Print the IP options of the original packet.

asomers accepted this revision.Mar 16 2023, 5:02 PM

This revision is now accepted and ready to land.Mar 16 2023, 5:02 PM

jlduran_gmail.com mentioned this in D38469: ping: Print the IP options of the original packet.Mar 16 2023, 6:11 PM

Closed by commit rG491263d7a640: ping: Avoid magic numbers (authored by jlduran_gmail.com, committed by markj). · Explain WhyMar 17 2023, 1:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG491263d7a640: ping: Avoid magic numbers.

markj added a commit: rG3c7ef29e8998: ping: Avoid magic numbers.Mar 24 2023, 4:59 PM

ping: Avoid magic numbers
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 118926

sbin/ping/ping.c

ping: Avoid magic numbersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 118926

sbin/ping/ping.c

ping: Avoid magic numbers
ClosedPublic
Actions

Revision Contents
Changeset List