Differential D39485

ping: Remove an extra new line character
ClosedPublic
Actions

Authored by jlduran on Apr 10 2023, 4:45 PM.

Details

Reviewers

markj

Group Reviewers

network

Commits

rGb0da2a3fa145: ping: Remove an extra new line character
rGd2c9a140547a: ping: Remove an extra new line character

Summary

This matches the behavior when an RR truncated route is printed.

Test Plan

kyua test -k /usr/tests/Kyuafile sbin/ping/ping_test
kyua test -k /usr/tests/Kyuafile sbin/ping/test_ping.py

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Apr 10 2023, 4:45 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 10 2023, 4:45 PM

jlduran requested review of this revision.Apr 10 2023, 4:45 PM

jlduran added a parent revision: D38528: ping: Test IHL/quoted data/inner packet paths.

jlduran added a child revision: D38484: ping: Specify the sigaction(2) name.Apr 10 2023, 4:47 PM

markj accepted this revision as: markj.Apr 10 2023, 4:50 PM

This revision is now accepted and ready to land.Apr 10 2023, 4:50 PM

Closed by commit rGd2c9a140547a: ping: Remove an extra new line character (authored by jlduran, committed by markj). · Explain WhyOct 11 2023, 6:01 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGd2c9a140547a: ping: Remove an extra new line character.

markj added a commit: rGb0da2a3fa145: ping: Remove an extra new line character.Nov 6 2023, 4:48 PM

Revision Contents
Changeset List

Path

Size

sbin/

ping/

ping.c

2 lines

tests/

test_ping.py

2 lines

Diff 128586

View Options

sbin/ping/ping.c