Inspired by: OpenBSD/Darwin
Obtained from: pfctl/parse.y (src), pf.conf.5 (man)
Details
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
sbin/ping/ping.8 | ||
---|---|---|
437 | Reading this, I would be confused by the difference if any between "netcontrol" and "inetcontrol" and which to use when. | |
440 | Audience check: would people reading this be familiar with the "DiffServ" abbreviation? (I assume it stands for "Differentiated Services".) | |
441–444 | I'd add a "see also" for the meaning of those. |
Thank you @pauamma! Those are great suggestions. I took man page changes from pf.conf.5, so I consider it to be my "upstream".
How about a change there, and then pull in those changes here?
sbin/ping/ping.8 | ||
---|---|---|
437 | I'm afraid I won't be able to change the name, as the idea is to mimic pf.conf(5), but we can detail what it means, as ipfw(8) does.
|
Sorry, I have not worked on the man page changes. I was waiting on the code review/approval first. I'll add @kp as a reviewer directly.
Thank you for reminding me about it!