Use the physical timer when able
ClosedPublic
Actions

Authored by andrew on Mar 15 2023, 2:18 PM.

Details

Reviewers

imp
kevans

Group Reviewers

ARM
arm64

Commits

rG02f3d094aead: Use the arm physical timer when able

Summary

To allow bhyve manage the virtual timer while in a guest have FreeBSD
use the virtual timer only when bhyve will be unavailable due to not
starting at EL2 where the hypervisor switcher will run.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/arm/arm/generic_timer.c:662	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 50378
Build 47269: arc lint + arc unit

Event Timeline

andrew created this revision.Mar 15 2023, 2:18 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 15 2023, 2:18 PM

andrew requested review of this revision.Mar 15 2023, 2:18 PM

Harbormaster completed remote builds in B50378: Diff 118850.Mar 15 2023, 2:18 PM

Fix a typo

Harbormaster completed remote builds in B50381: Diff 118853.Mar 15 2023, 2:19 PM

Assuming we know the res is always non-null in these cases, I think we're good. I kinda think they should be, but that's just from a quick read.

sys/arm/arm/generic_timer.c
664	only question: are we guaranteed that these timers will be around in this case? Similar below...

This revision is now accepted and ready to land.Mar 15 2023, 2:55 PM

andrew added inline comments.Mar 15 2023, 3:27 PM

sys/arm/arm/generic_timer.c
664	We require the virtual and physical timer interrupts as they are marked non-optional in `arm_tmr_irq_defs`

kevans accepted this revision as: kevans.Mar 15 2023, 3:38 PM

Closed by commit rG02f3d094aead: Use the arm physical timer when able (authored by andrew). · Explain WhyMar 15 2023, 3:49 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG02f3d094aead: Use the arm physical timer when able.

Revision Contents
Changeset List

Path

Size

sys/

arm/

generic_timer.c

18 lines

Diff 118850

View Options

sys/arm/arm/generic_timer.c

Use the physical timer when ableClosedPublicActions