The order of the interrupt array doesn't matter. Store the described
interrupts at the start of the array to simplify iterating over them.
Sponsored by: Arm Ltd
Details
Details
- Reviewers
imp kevans - Group Reviewers
ARM arm64 - Commits
- rG289967bbad82: Stop using the rid as an index in the arm timer
rG5c4bd8756fbc: Stop using the rid as an index in the arm timer
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
All looks straight forward. No real functional change here. No need to randomly access the array either, just iterate over it.
| sys/arm/arm/generic_timer.c | ||
|---|---|---|
| 702 | I believe we still want the rid here. Is it worth releasing resources for these interrupts that we're now skipping, since we've already decided which we'll be using? | |
| sys/arm/arm/generic_timer.c | ||
|---|---|---|
| 702 | The rid may change, e.g. when using interrupt-names. The index is used as a internal ID and default rid when interrupt-names isn't used. We could drop the resource, however that may lead to holes in the array so er would need to memmove later entries to keep the array packed. | |
| sys/arm/arm/generic_timer.c | ||
|---|---|---|
| 702 | Ahh, fair point- thanks! I had overlooked that idx was assigned the original idx specified in arm_tmr_irq_defs, which makes sense. | |