arm64: use non-posted device memory if nonposted-mmio is set
AbandonedPublic
Actions

Authored by kevans on Mar 3 2023, 5:01 PM.

Details

Reviewers

manu

Group Reviewers

arm64

Summary

Apple silicon machines need nonposted memory for a number of devices,
and it's denoted by setting nonposted-mmio on the parent simple-bus.
Look out for the nonposted-mmio prop and honor it if it's found,
otherwise use nGnRE.

(I think this patch was entirely Andy, and I've tentatively set --author
as such)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 50133
Build 47025: arc lint + arc unit

Event Timeline

kevans created this revision.Mar 3 2023, 5:01 PM

Herald added a reviewer: manu. · View Herald TranscriptMar 3 2023, 5:01 PM

Herald added subscribers: emaste, andrew, imp. · View Herald Transcript

kevans requested review of this revision.Mar 3 2023, 5:01 PM

Harbormaster completed remote builds in B50133: Diff 118272.Mar 3 2023, 5:01 PM

(I think this patch was entirely Andy, and I've tentatively set --author as such)

Yes, D34333. I don't remember why I didn't commit that one. Maybe it was because of the PCI issue, althought I have D30079 for that.

sys/arm64/arm64/nexus.c
392	I think this should be `VM_MEMATTR_DEVICE`. It's currently the same as `VM_MEMATTR_DEVICE_NP` because PCIe config space needs it to be non-posted, but if we can fix the PCIe drivers we can change it & this code will then e correct.

Abandon in favor of D34333

Revision Contents
Changeset List

Path

Size

sys/

arm64/

nexus.c

58 lines

Diff 118272

View Options

arm64: use non-posted device memory if nonposted-mmio is setAbandonedPublicActions