Page MenuHomeFreeBSD

Properly conditionalize clang 15-only flags
ClosedPublic

Authored by imp on Feb 12 2023, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 1:55 AM
Unknown Object (File)
Fri, Nov 15, 1:37 AM
Unknown Object (File)
Thu, Nov 14, 10:17 PM
Unknown Object (File)
Oct 14 2024, 6:14 AM
Unknown Object (File)
Oct 9 2024, 12:05 PM
Unknown Object (File)
Oct 5 2024, 8:45 PM
Unknown Object (File)
Sep 30 2024, 1:38 PM
Unknown Object (File)
Sep 23 2024, 5:33 AM
Subscribers

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Feb 12 2023, 9:47 PM
imp created this revision.

ah, we do pull in bsd.sys.mk, so this already exists.

Add issue from xlib upstream that xin li sent me back in december when I climbed
this hill for stand.

This revision is now accepted and ready to land.Feb 13 2023, 2:48 AM

you missed this bit:

diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefile
index 6391255e512b..178d3a3f7ab7 100644
--- a/sys/modules/zlib/Makefile
+++ b/sys/modules/zlib/Makefile
@@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=${NO_WSTRICT_PROTOTYPES} # crc32.c:586
 CWARNFLAGS.trees.c+=${NO_WSTRICT_PROTOTYPES} # trees.c:232
 CWARNFLAGS.zutil.c+=${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32
 
+CWARNFLAGS+=-Wno-deprecated-non-prototype
+

Note the ${NO_WDEPRECATED_NON_PROTOTYPE}

Edit: Oh, the module makefile -- yes.

This revision was automatically updated to reflect the committed changes.
In D38550#877140, @mjg wrote:

you missed this bit:

diff --git a/sys/modules/zlib/Makefile b/sys/modules/zlib/Makefile
index 6391255e512b..178d3a3f7ab7 100644
--- a/sys/modules/zlib/Makefile
+++ b/sys/modules/zlib/Makefile
@@ -25,4 +25,6 @@ CWARNFLAGS.crc32.c+=${NO_WSTRICT_PROTOTYPES} # crc32.c:586
 CWARNFLAGS.trees.c+=${NO_WSTRICT_PROTOTYPES} # trees.c:232
 CWARNFLAGS.zutil.c+=${NO_WSTRICT_PROTOTYPES} # zutil.c:27,32
 
+CWARNFLAGS+=-Wno-deprecated-non-prototype
+

Thanks! I'll followup. I missed this before committing.

jhb added inline comments.
sys/conf/kern.pre.mk
283

I'm curious why you replaced ${NO_WSTRICT_PROTOTYPES} above with the literal version here?

sys/conf/kern.pre.mk
283

So about that... yea... that's clearly a mistake... I'll fix it.