Page MenuHomeFreeBSD

bhyve: add common fwcfg items
ClosedPublic

Authored by corvink on Feb 1 2023, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 20, 10:27 AM
Unknown Object (File)
Thu, Sep 19, 3:26 PM
Unknown Object (File)
Thu, Sep 19, 4:56 AM
Unknown Object (File)
Wed, Sep 18, 6:00 PM
Unknown Object (File)
Wed, Sep 18, 5:33 AM
Unknown Object (File)
Tue, Sep 17, 3:55 PM
Unknown Object (File)
Tue, Sep 17, 10:55 AM
Unknown Object (File)
Mon, Sep 16, 11:33 AM
Subscribers

Details

Summary

Qemu defines some common fwcfg items. We don't need to support all of
them. Only a subset needs to be present for fwcfg to work properly.

  • signature The signature is used by the guest to check if qemu's fwcfg is available or not.
  • id The id is used by the guest to check which features are supported by the fwcfg implementation of the hypervisor.
  • file_dir The file dir reports all fwcfg items which don't have a fixed index. These are mostly user defined fwcfg items.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 49407
Build 46297: arc lint + arc unit

Event Timeline

usr.sbin/bhyve/qemu_fwcfg.c
193
200

Why a negative value?

208

This line is too long, missing parens around the return value.

markj added inline comments.
usr.sbin/bhyve/qemu_fwcfg.c
203

This style of commenting is useless IMHO. It would be much more useful to, for example, describe the information that is encoded in this directory structure.

This revision is now accepted and ready to land.Feb 14 2023, 2:55 PM
This revision was automatically updated to reflect the committed changes.