bhyve: add helper to add fwcfg items
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:10 AM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG1adfb2e834c5: bhyve: add helper to add fwcfg items
rG3ef46195ac37: bhyve: add helper to add fwcfg items

Summary

This helper makes it easier to add multiple fwcfg items. You can pass an
index and some data to the helper. The helper adds these information to
the fwcfg emulation so that the guest reads the given data on the
specified index.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Feb 1 2023, 11:10 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:10 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

corvink requested review of this revision.Feb 1 2023, 11:10 AM

Harbormaster completed remote builds in B49406: Diff 116190.Feb 1 2023, 11:10 AM

corvink mentioned this in D31578: bhyve: add support for QEMU's fwcfg.Feb 1 2023, 11:15 AM

corvink added a parent revision: D38333: bhyve: add emulation for qemu's fwcfg data port.

corvink added a child revision: D38335: bhyve: add common fwcfg items.

markj added inline comments.Feb 2 2023, 2:24 PM

usr.sbin/bhyve/qemu_fwcfg.c
142	Should we validate the indices, if only with `assert()`?

rebase

Harbormaster completed remote builds in B49591: Diff 116680.Feb 7 2023, 7:44 AM

corvink added inline comments.Feb 7 2023, 8:02 AM

usr.sbin/bhyve/qemu_fwcfg.c
142	I'm not sure about this. `items` is defined as `struct qemu_fwcfg_item items[QEMU_FWCFG_MAX_ARCHS][QEMU_FWCFG_MAX_ENTRIES];`. The value of idx is masked. So, it's impossible for idx to be too large.