bhyve: add basic qemu fwcfg implementation
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:10 AM.

Details

Reviewers

jhb
markj

Group Reviewers

bhyve

Commits

rG0232125972f5: bhyve: add basic qemu fwcfg implementation
rG9b99de77f160: bhyve: add basic qemu fwcfg implementation

Summary

qemu's fwcfg and bhyve's fwctl are both used to configure ovmf. qemu's
fwcfg is much more powerfull than bhyve's fwctl. For that reason, add
support for qemu's fwcfg.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Feb 1 2023, 11:10 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:10 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

corvink requested review of this revision.Feb 1 2023, 11:10 AM

Harbormaster completed remote builds in B49403: Diff 116187.Feb 1 2023, 11:10 AM

corvink added a parent revision: D38330: bhyve: maintain a list of acpi devices.Feb 1 2023, 11:14 AM

corvink added a child revision: D38332: bhyve: add emulation for the qemu fwcfg selector port.

corvink mentioned this in D31578: bhyve: add support for QEMU's fwcfg.

markj added inline comments.Feb 2 2023, 2:19 PM

usr.sbin/bhyve/qemu_fwcfg.c
43	Why does the softc need to be packed?
45	Since this is a global, let's give it a more specific name? Perhaps `fwcfg_sc`.
76
104	Continuing lines should be indented by four spaces, same below.