Paths

Table of Contentst

Add the fixed memory type to the pci ecam driver
ClosedPublic
Actions

Authored by andrew on Jan 12 2023, 9:41 AM.

Details

Reviewers

jhb
fuz

Group Reviewers

arm64

Commits

rG253e4c56c8a6: Add the fixed memory type to the pci ecam driver
rG896f556205c8: Add the fixed memory type to the pci ecam driver

Summary

Add ACPI_RESOURCE_TYPE_FIXED_MEMORY32 to the PCI ECAM driver. This is
used on the Microsoft Dev Kit 2023 and reportedly the Lenovo x13s.

Tested by: Robert Clausecker <fuz@fuz.su> (Earlier version)
Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49089
Build 45978: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 12 2023, 9:41 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 12 2023, 9:41 AM

andrew requested review of this revision.Jan 12 2023, 9:41 AM

Harbormaster completed remote builds in B49071: Diff 114989.Jan 12 2023, 9:41 AM

This patch tests ok on the Windows 2023 Dev Kit.

sys/dev/pci/pci_host_generic_acpi.c
151	Code could be made less repetitive by moving the standard case out of the switch statement.

This revision is now accepted and ready to land.Jan 12 2023, 10:55 AM

kevans added a subscriber: kevans.Jan 12 2023, 8:04 PM

kevans added inline comments.

sys/dev/pci/pci_host_generic_acpi.c
171

Use the correct union member to find the resource type
Fix a typo

This revision now requires review to proceed.Jan 13 2023, 4:03 PM

Harbormaster completed remote builds in B49089: Diff 115044.Jan 13 2023, 4:03 PM

andrew marked an inline comment as done.Jan 13 2023, 4:06 PM

andrew added inline comments.

sys/dev/pci/pci_host_generic_acpi.c
151	I switched to using the correct union member rather than rely on it being part of the `Address` member.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2023, 9:41 AM

Closed by commit rG896f556205c8: Add the fixed memory type to the pci ecam driver (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG896f556205c8: Add the fixed memory type to the pci ecam driver.

This patch apparently has not been MFC'ed to 13-stable, preventing the Windows 2023 Dev Kit from booting 13.2-RC6 (in conjunction with D37765 and hw.pac.enable=0). Could this one be MFC'ed?

andrew added a commit: rG253e4c56c8a6: Add the fixed memory type to the pci ecam driver.May 15 2023, 3:46 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic_acpi.c

23 lines

Diff 115044

View Options

sys/dev/pci/pci_host_generic_acpi.c

Add the fixed memory type to the pci ecam driverClosedPublicActions