Reduce an arm64 VFP critical section
ClosedPublic
Actions

Authored by andrew on Jan 9 2023, 9:20 PM.

Details

Reviewers

kib
manu

Group Reviewers

arm64

Commits

rG0ae7446ed3fa: Reduce an arm64 VFP critical section
rGa85cf421d1bf: Reduce an arm64 VFP critical section

Summary

In set_fpcontext we only need a critical section around vfp_discard.
The remainder of the code can run without it.

While here add an assert to check the passed in thread is the
current thread as the code already this.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 49027
Build 45916: arc lint + arc unit

Event Timeline

andrew created this revision.Jan 9 2023, 9:20 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 9 2023, 9:20 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B49027: Diff 114907.Jan 9 2023, 9:20 PM

andrew requested review of this revision.Jan 9 2023, 9:20 PM

Duplicate of D37998 due to an incorrect git arc command

Abandoned wron review

andrew mentioned this in D37419: arm: Add support for using VFP in kernel.Jan 10 2023, 10:05 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2023, 9:41 AM

Closed by commit rGa85cf421d1bf: Reduce an arm64 VFP critical section (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGa85cf421d1bf: Reduce an arm64 VFP critical section.

andrew added a commit: rG0ae7446ed3fa: Reduce an arm64 VFP critical section.May 15 2023, 3:46 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

exec_machdep.c

7 lines

Diff 114907

View Options

sys/arm64/arm64/exec_machdep.c

Reduce an arm64 VFP critical sectionClosedPublicActions