Page MenuHomeFreeBSD
Differential D37406

bhyve: add helper to append a basl table without a header
ClosedPublic
Actions

Authored by corvink on Nov 16 2022, 12:50 PM.
Tags
None
Referenced Files
F102672089: D37406.diff
Fri, Nov 15, 4:09 PM
Unknown Object (File)
Sat, Oct 26, 9:47 PM
Unknown Object (File)
Sat, Oct 26, 9:46 PM
Unknown Object (File)
Sat, Oct 26, 9:46 PM
Unknown Object (File)
Sat, Oct 26, 8:11 PM
Unknown Object (File)
Oct 9 2024, 4:54 AM
Unknown Object (File)
Oct 4 2024, 2:02 AM
Unknown Object (File)
Oct 1 2024, 3:08 PM
View All 64 Files
Subscribers
bcran
imp
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rGc8029c30a872: bhyve: add helper to append a basl table without a header
rG8897b562abbf: bhyve: add helper to append a basl table without a header
Summary

The common style for build an ACPI table will be:

  1. basl_table_create
  2. basl_table_append_header
  3. setup an ACPI_TABLE_* struct
  4. basl_table_append_bytes (without header)

Add a helper for the last step.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 48383
Build 45269: arc lint + arc unit

Event Timeline

corvink created this revision.Nov 16 2022, 12:50 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptNov 16 2022, 12:50 PM
corvink requested review of this revision.Nov 16 2022, 12:50 PM
Harbormaster completed remote builds in B48383: Diff 113198.Nov 16 2022, 12:50 PM
markj accepted this revision as: markj.Nov 16 2022, 2:25 PM
markj added inline comments.
usr.sbin/bhyve/basl.c
444

Assert len >= sizeof(ACPI_TABLE_HEADER)?

448

Missing parens around the return value.

usr.sbin/bhyve/basl.h
53
This revision is now accepted and ready to land.Nov 16 2022, 2:25 PM
corvink added a child revision: D36995: [PATCH 12/19] bhyve: build MCFG table by basl.Nov 17 2022, 7:30 AM
corvink added a parent revision: D37405: bhyve: make basl_table_add_* functions public.
jhb added a comment.Nov 17 2022, 5:54 PM

Agree with @markj's feedback, but like the idea of a helper function for this.

jhb accepted this revision.Nov 17 2022, 5:54 PM
Closed by commit rG8897b562abbf: bhyve: add helper to append a basl table without a header (authored by corvink). · Explain WhyNov 21 2022, 8:32 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG8897b562abbf: bhyve: add helper to append a basl table without a header.
corvink added a commit: rGc8029c30a872: bhyve: add helper to append a basl table without a header.Dec 5 2022, 7:42 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
3 lines
10 lines

Diff 113198

View Options

usr.sbin/bhyve/basl.h

Loading...
View Options

usr.sbin/bhyve/basl.c

Loading...