Page MenuHomeFreeBSD

[PATCH 18/19] bhyve: build RSDP table by basl
ClosedPublic

Authored by corvink on Oct 14 2022, 9:31 AM.
Tags
Referenced Files
Unknown Object (File)
Sat, Oct 26, 10:11 PM
Unknown Object (File)
Sat, Oct 26, 10:10 PM
Unknown Object (File)
Thu, Oct 17, 7:28 PM
Unknown Object (File)
Oct 8 2024, 8:03 AM
Unknown Object (File)
Sep 20 2024, 3:31 AM
Unknown Object (File)
Sep 20 2024, 12:02 AM
Unknown Object (File)
Sep 19 2024, 3:25 PM
Unknown Object (File)
Sep 18 2024, 10:51 PM
Subscribers

Details

Summary

Building the RSDP table by basl will allow it to be loaded by qemu's
ACPI table loader.

This is the 18. patch required to merge D36983

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink retitled this revision from [acpi-table part 18] bhyve: build RSDP table by basl to [PATCH 18/19] bhyve: build RSDP table by basl.Oct 14 2022, 9:45 AM
markj added inline comments.
usr.sbin/bhyve/acpi.c
779

This comment isn't really accurate anymore, here we're just building up representations of the tables.

This revision is now accepted and ready to land.Nov 2 2022, 1:55 PM
This revision now requires review to proceed.Nov 15 2022, 10:09 AM
usr.sbin/bhyve/acpi.c
694

Might also be nice to use ACPI_TABLE_RSDP here (but would need basl_table_add_pointer).

771

Might be nice to still say something like "Generate ACPI tables and copy them into guest memory."

  • use ACPI_TABLE_* structs for building
jhb added inline comments.
usr.sbin/bhyve/acpi.c
673

This should probably be added to the earlier MCFG patch.

This revision is now accepted and ready to land.Nov 17 2022, 6:01 PM
This revision was automatically updated to reflect the committed changes.