[PATCH 14/19] bhyve: build MADT table by basl

[corvink]

Summary

Building the MADT table by basl will allow it to be loaded by qemu's
ACPI table loader.

This is the 14. patch required to merge D36983

[markj]

usr.sbin/bhyve/acpi.c

873

This was ACTIVE_HIGH and TRIGGER_EDGE in the old version.

[corvink]

usr.sbin/bhyve/acpi.c

873

Good catch. Thank you.

[corvink]

• I've compared the ACPI output before and after this commit and fixed wrong entries

[corvink]

• inline defines

[jhb]

usr.sbin/bhyve/acpi.c

828

For these I think it would be nicer to use the structures from actbl2.h such as ACPI_MADT_LOCAL_APIC. For example:

for (int i = 0; i < basl_ncpu; ++i) {
    ACPI_MADT_LOCAL_APIC local_apic;

    local_apic.Header.Type = ACPI_MADT_TYPE_LOCAL_APIC;
    local_apic.Header.Length = sizeof(local_apic);
    local_apic.ProcessorId = i;
    local_apic.Id = i;
    local_apic.LapicFlags = htole32(ACPI_MADT_ENABLED);

    BASL_EXEC(basl_table_append_bytes(madt, &local_apic, sizeof(local_apic));
}

[corvink]

• use ACPI_TABLE_* structs for building