Page MenuHomeFreeBSD

Support the arm64 pmap_remove_write for stage 2
ClosedPublic

Authored by andrew on Nov 15 2022, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 16, 4:45 AM
Unknown Object (File)
Sat, Nov 16, 4:34 AM
Unknown Object (File)
Sat, Nov 16, 4:29 AM
Unknown Object (File)
Sat, Nov 16, 2:42 AM
Unknown Object (File)
Thu, Nov 7, 2:01 PM
Unknown Object (File)
Thu, Nov 7, 3:29 AM
Unknown Object (File)
Wed, Nov 6, 7:14 AM
Unknown Object (File)
Oct 17 2024, 10:17 AM
Subscribers

Details

Summary

The fields we need to adjust are different in stage 1 and stage 2
tables. Handle this by adding variables to hold the bits to check,
set, and clear.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You might take a look at PG_RW/PG_V, pmap_valid_bit()/pmap_rw_bit() in amd64 pmap.

This revision is now accepted and ready to land.Nov 16 2022, 5:25 AM
sys/arm64/arm64/pmap.c
5876

This is incorrect. ATTR_S1_AP(ATTR_S1_AP_RW) is equal to 0. So, the original code calls vm_page_dirty() if (oldpte & ATTR_S1_AP_RW_BIT) == 0.

Fix the check before calling vm_page_dirty

This revision now requires review to proceed.Nov 17 2022, 12:17 PM
This revision is now accepted and ready to land.Nov 20 2022, 1:16 AM