[PATCH 2/19] bhyve: add table dump functions for basl

[corvink]

Summary

Developing an ACPI table compiler isn't quite easy. It's helpful if you
can take a look at the ACPI tables created by the compiler.

The dump functions can either dump a ACPI table which was copied into
guest memory or a ACPI table provided for qemu's ACPI table loader.

This is the second patch required to merge D36983

[markj]

usr.sbin/bhyve/basl.c

39

Looks like mem can be bool.

47

No need for a cast here.

54

Why is \r needed? Ditto below.

73

88

Let's be consistent and include an extra newline between variable declarations and the rest of the function body, like basl_dump_table() does. This is required by style(9) too.

89

[corvink]

• address feedback of markj

[markj]

usr.sbin/bhyve/basl.c

86

This one should also be bool.

[corvink]

• correct usage of isprint

[jhb]

usr.sbin/bhyve/basl.c

57

You might be able to replace this loop with a call to hexdump(3) from libutil.

[corvink]

• use hexdump for dumping ACPI tables

[corvink]

usr.sbin/bhyve/basl.c

57

Good idea. Thanks.