git-arc: Just strip escape sequences form arc log

[imp]

Summary

Just strip escape sequences and Warning: lines from 'arc list' output. I
upgraded and they changed and git arc list broke. This restores its
functionality.

Sponsored by: Netflix

[imp]

Yea, let's acutally do post the code that worked rather than the crazy
experiment that's best forgotten.

[markj]

I'm fine with the change in principle, but could you please lift "arc list" invocations into a subroutine which does the filtering and includes a comment explaining why we do it? Something like

arc_list()
{
    arc list | sed ...
}

tools/tools/git/git-arc.sh

417

Above you exclude "^Warning: module" but here it's just ^Warning.

[imp]

update, per markj

[imp]

tools/tools/git/git-arc.sh

417

Yea, that's bogus. Fixed in respin

[markj]

tools/tools/git/git-arc.sh

147

Not really "stray" they're just a result of colourized output, which seems impossible to turn off. :(

[imp]

tools/tools/git/git-arc.sh

147

I'll reword Tobe sparky towards the lack of a --no-color option...

[jhb]

Hmm, does this mean 'git arc list' no longer lists the colorized output it did before?

[imp]

In D36553#910901, @jhb wrote:

Hmm, does this mean 'git arc list' no longer lists the colorized output it did before?

Yes. That's a side effect

[imp]

use "$@" instead of $*. This is better (see sh(1))

[markj]

In D36553#910939, @imp wrote:

In D36553#910901, @jhb wrote:

Hmm, does this mean 'git arc list' no longer lists the colorized output it did before?

Yes. That's a side effect

That's fine with me, but John or others might consider that a regression?

[jhb]

I must admit I am quite used to the color output and depend on it to stand out accepted from needs review, etc in the list output. I kept the colors intentionally in the original version of list.

[imp]

In D36553#911581, @jhb wrote:

I must admit I am quite used to the color output and depend on it to stand out accepted from needs review, etc in the list output. I kept the colors intentionally in the original version of list.

I can omit this part of the series and we can chat at bsdcan... I like the color, but haven't missed it and it appears the issues I had with it have been worked around in other ways in the interim