Page MenuHomeFreeBSD
Differential D36488

tcp: avoid call to soisconnected() on transition to ESTABLISHED
ClosedPublic
Actions

Authored by glebius on Sep 7 2022, 10:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 28, 4:12 PM
Unknown Object (File)
Thu, Sep 26, 9:05 AM
Unknown Object (File)
Tue, Sep 24, 5:33 PM
Unknown Object (File)
Mon, Sep 23, 10:44 AM
Unknown Object (File)
Sun, Sep 22, 3:49 PM
Unknown Object (File)
Sat, Sep 21, 4:41 AM
Unknown Object (File)
Wed, Sep 18, 12:48 AM
Unknown Object (File)
Sun, Sep 15, 5:15 PM
View All 59 Files
Subscribers
imp
melifaro

Details

Reviewers
rrs
tuexen
Group Reviewers
transport
Commits
rGe80062a2d433: tcp: avoid call to soisconnected() on transition to ESTABLISHED
Summary

This call existed since pre-FreeBSD times, and it is hard to understand
why it was there in the first place. After 6f3caa6d815 it definitely
became necessary always and commit message from f1ee30ccd60 confirms that.
Now that 6f3caa6d815 is effectively backed out by 07285bb4c22, the call
appears to be useful only for sockets that landed on the imcomplete queue,
e.g. sockets that have accept_filter(9) enabled on them.

Provide a new TCP flag to mark connections that are known to be on the
incomplete queue, and call soisconnected() only for those connections.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47287
Build 44174: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
kern/
8 lines
netinet/
5 lines
3 lines
4 lines
2 lines
sys/
2 lines

Diff 110333

View Options

sys/kern/uipc_socket.c

Loading...
View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_syncache.c

Loading...
View Options

sys/netinet/tcp_usrreq.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...
View Options

sys/sys/socketvar.h

Loading...