Page MenuHomeFreeBSD
Differential D36310

arm64 pmap: implement per-superpage locks
ClosedPublic
Actions

Authored by andrew on Aug 23 2022, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 30, 5:54 AM
Unknown Object (File)
Oct 2 2024, 12:35 PM
Unknown Object (File)
Oct 2 2024, 12:27 PM
Unknown Object (File)
Sep 27 2024, 5:45 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 27 2024, 5:22 PM
Unknown Object (File)
Sep 27 2024, 5:21 PM
Unknown Object (File)
Sep 27 2024, 5:21 PM
View All 82 Files
Subscribers
emaste
imp

Details

Reviewers
alc
mjg
markj
kib
manu
Group Reviewers
arm64
Commits
rGc15085278cb5: arm64 pmap: implement per-superpage locks
Summary

As with amd64 pmap introduce per-superpage locks backed by pages
allocated by their respective domains.

This significiantly reduces lock contantion from pmap when running
poudriere on a 160 core Ampere Altra server

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47263
Build 44150: arc lint + arc unit

Event Timeline

andrew created this revision.Aug 23 2022, 12:24 PM
Herald added a reviewer: manu. · View Herald TranscriptAug 23 2022, 12:24 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Aug 23 2022, 12:24 PM
Harbormaster completed remote builds in B47077: Diff 109715.Aug 23 2022, 12:24 PM
markj added a comment.Aug 29 2022, 4:03 PM

Why do we continue to implement the old locking scheme if NUMA isn't configured? It seems more complicated than necessary, and it's not only NUMA systems that suffer from pv list lock contention. Graviton EC2 instances always have a single memory domain, and one might disable NUMA in the kernel config.

sys/arm64/arm64/pmap.c
195
1386–1387
1411

Pass VM_ALLOC_ZERO to vm_page_alloc_noobj_domain() instead of calling pmap_zero_page().

1564

Extra newline.

andrew updated this revision to Diff 110211.Sep 6 2022, 12:39 PM
andrew marked 4 inline comments as done.

Fixes from feedback by @markj

Harbormaster completed remote builds in B47262: Diff 110211.Sep 6 2022, 12:39 PM
andrew updated this revision to Diff 110212.Sep 6 2022, 12:40 PM

Use the correct diff

Harbormaster completed remote builds in B47263: Diff 110212.Sep 6 2022, 12:40 PM
andrew updated this revision to Diff 111079.Sep 27 2022, 3:11 PM

Remove NUMA checks

Harbormaster completed remote builds in B47564: Diff 111079.Sep 27 2022, 3:11 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 17 2022, 5:13 PM
Closed by commit rGc15085278cb5: arm64 pmap: implement per-superpage locks (authored by andrew). · Explain Why
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rGc15085278cb5: arm64 pmap: implement per-superpage locks.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
247 lines

Diff 110212

View Options

sys/arm64/arm64/pmap.c

Loading...