Now that we can PVH boot on a non-Xen hypervisor, we shouldn't set
machdep.bootmethod to "XEN" unconditionally. Instead, set it to
"XEN" if we're running under Xen and "PVH" otherwise.
Details
Details
- Reviewers
royger imp - Commits
- rG13f34e211b5c: PVH: Set bootmethod to PVH
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I'm assuming that the whole issue of overloading boot method with what bios interface is available isn't made worse by this :)
Comment Actions
Right, in this case we're not really booting with PC BIOS *or* UEFI.
I don't think it really matters here, but it caught my eye when I ran sysctl -a | grep -i xen so I figured I might as well fix it. In the longer term I expect this file to move to sys/x86/x86/pvh.c so we can more fully separate "PVH" and "Xen PVH", so this code will be churned later anyway.
Comment Actions
I think I would prefer setting it to PVH in both cases, we have other ways to expose the underlying hypervisor, and the boot entry point is the same for Xen or KVM PVH.