Paths

Table of Contentst

Differential D36128

raw ip6: merge rip6_output() into rip6_send()
ClosedPublic
Actions

Authored by glebius on Aug 10 2022, 11:51 PM.

Tags

None

Referenced Files

	F97644580: D36128.diff
	Mon, Sep 30, 1:39 PM

	Unknown Object (File)
	Mon, Sep 30, 7:01 AM

	Unknown Object (File)
	Tue, Sep 24, 2:23 AM

	Unknown Object (File)
	Tue, Sep 10, 9:47 AM

	Unknown Object (File)
	Tue, Sep 10, 12:18 AM

	Unknown Object (File)
	Mon, Sep 9, 9:40 PM

	Unknown Object (File)
	Wed, Sep 4, 10:58 PM

	Unknown Object (File)
	Sun, Sep 1, 2:49 PM

View All 63 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGe0b405003a2a: raw ip6: merge rip6_output() into rip6_send()

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/netinet6/raw_ip6.c:368	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:393	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:407	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:409	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:411	SPELL1	Possible Spelling Mistake
Warning	sys/netinet6/raw_ip6.c:417	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 46845
Build 43734: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 10 2022, 11:51 PM

Herald added subscribers: bz, ae, imp. · View Herald TranscriptAug 10 2022, 11:51 PM

glebius requested review of this revision.Aug 10 2022, 11:51 PM

glebius added a parent revision: D36127: raw ip: merge rip_output() into rip_send().

Harbormaster completed remote builds in B46845: Diff 109133.Aug 10 2022, 11:51 PM

melifaro accepted this revision.Aug 11 2022, 8:54 AM

melifaro added inline comments.

sys/netinet6/raw_ip6.c
397–400	Nit: probably worth doing static init for `tmp`
419	This code was added in 2005 ( a1f7e5f8ee7fe ) and already mentioned backward compatibility. Given that these changes are not likely to be merged to stable, maybe worth considering removing it?

This revision is now accepted and ready to land.Aug 11 2022, 8:54 AM

This revision was landed with ongoing or failed builds.Aug 11 2022, 4:20 PM

Closed by commit rGe0b405003a2a: raw ip6: merge rip6_output() into rip6_send() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGe0b405003a2a: raw ip6: merge rip6_output() into rip6_send().

Revision Contents
Changeset List

Path

Size

sys/

netinet6/

1 line

135 lines

Diff 109133

sys/netinet6/ip6_var.h

Loading...

sys/netinet6/raw_ip6.c

Loading...