rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value
ClosedPublic
Actions

Authored by glebius on Aug 10 2022, 7:22 PM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rGd94ec7490d31: rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value

Summary

Use local storage of the mbuf packet header instead.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Aug 10 2022, 7:22 PM

Herald added subscribers: ae, imp. · View Herald TranscriptAug 10 2022, 7:22 PM

glebius requested review of this revision.Aug 10 2022, 7:22 PM

Harbormaster completed remote builds in B46838: Diff 109121.Aug 10 2022, 7:22 PM

glebius added a child revision: D36122: rtsock: do not use raw socket code.Aug 10 2022, 7:22 PM

melifaro accepted this revision.Aug 11 2022, 7:57 AM

melifaro added inline comments.

sys/net/rtsock.c
160	Nit: I'd rather name it something like `m_rtsock_family` to indicate that this is a local field.

This revision is now accepted and ready to land.Aug 11 2022, 7:57 AM

Closed by commit rGd94ec7490d31: rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value (authored by glebius). · Explain WhyAug 11 2022, 4:20 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rGd94ec7490d31: rtsock: do not allocate mbufs_tags(9) just to store a 8-bit value.

Revision Contents
Changeset List

Path

Size

sys/

net/

rtsock.c

33 lines

sys/

mbuf.h

2 lines

Diff 109172

View Options

sys/net/rtsock.c