Differential D36127

raw ip: merge rip_output() into rip_send()
ClosedPublic
Actions

Authored by glebius on Aug 10 2022, 11:51 PM.

Details

Reviewers

melifaro

Group Reviewers

network

Commits

rG3d2041c0353d: raw ip: merge rip_output() into rip_send()

Summary

While here, address the unlocked 'dst' read. Solve that by storing
a pointer either to the inpcb or to the sockaddr. If we end up
copying address out of the inpcb, that would be done under the read
lock section.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	sys/netinet/raw_ip.c:410	SPELL1	Possible Spelling Mistake
Warning	sys/netinet/raw_ip.c:429	SPELL1	Possible Spelling Mistake
Warning	sys/netinet/raw_ip.c:436	SPELL1	Possible Spelling Mistake
Warning	sys/netinet/raw_ip.c:438	SPELL1	Possible Spelling Mistake
Warning	sys/netinet/raw_ip.c:440	SPELL1	Possible Spelling Mistake
Warning	sys/netinet/raw_ip.c:448	SPELL1	Possible Spelling Mistake

Unit

No Test Coverage

Build Status

Buildable 46844
Build 43733: arc lint + arc unit

Event Timeline

glebius created this revision.Aug 10 2022, 11:51 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2022, 11:51 PM

glebius requested review of this revision.Aug 10 2022, 11:51 PM

Harbormaster completed remote builds in B46844: Diff 109132.Aug 10 2022, 11:51 PM

glebius added a parent revision: D36126: protosw: retire pr_output method.Aug 10 2022, 11:51 PM

glebius added a child revision: D36128: raw ip6: merge rip6_output() into rip6_send().

melifaro accepted this revision.Aug 11 2022, 8:40 AM

This revision is now accepted and ready to land.Aug 11 2022, 8:40 AM

melifaro added inline comments.Aug 11 2022, 8:42 AM

sys/netinet/raw_ip.c
434	Q: why do we store reference instead of just saving the value?

glebius marked an inline comment as done.Aug 11 2022, 2:46 PM

glebius added inline comments.

sys/netinet/raw_ip.c
434	At this point inp isn't locked. On the copyout it will be locked. Well, inp_faddr can not change, I believe. But reading value out in the locked section, kinda more cool.

This revision was landed with ongoing or failed builds.Aug 11 2022, 4:20 PM

Closed by commit rG3d2041c0353d: raw ip: merge rip_output() into rip_send() (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius marked an inline comment as done.

glebius added a commit: rG3d2041c0353d: raw ip: merge rip_output() into rip_send().