vm_fault: Remove a redundant parameter to vm_fault_quick_hold_pages()
AbandonedPublic
Actions

Authored by markj on Jul 25 2022, 2:58 PM.

Details

Reviewers

kib
alc
dougm

Group Reviewers

transport
bhyve

Summary

It looks like this parameter was meant to allow extra pages to be
fetched opportunistically, but this is not implemented. We could add a
new interface to provide this functionality if needed.

No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46549
Build 43438: arc lint + arc unit

Event Timeline

markj created this revision.Jul 25 2022, 2:58 PM

Herald added a reviewer: transport. · View Herald TranscriptJul 25 2022, 2:58 PM

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: linuxkpi, glebius, melifaro and 6 others. · View Herald Transcript

markj requested review of this revision.Jul 25 2022, 2:58 PM

Harbormaster completed remote builds in B46549: Diff 108496.Jul 25 2022, 2:58 PM

markj added a parent revision: D35905: vm_object: Widen the flags field.Jul 25 2022, 2:58 PM

I do not remember for sure, but most likely the idea with max_count was to avoid silly driver mistakes typically causing the kernel stack overwrite. The panic() and not KASSERT() is there for this reason, same as e.g. vm_page_free_prep() panic for the referenced/wired page.

In D35906#815417, @kib wrote:

I do not remember for sure, but most likely the idea with max_count was to avoid silly driver mistakes typically causing the kernel stack overwrite. The panic() and not KASSERT() is there for this reason, same as e.g. vm_page_free_prep() panic for the referenced/wired page.

Ok, I will drop it for now.