Disallow invalid PT_GNU_STACK
ClosedPublic
Actions

Authored by emaste on Jul 20 2022, 4:25 PM.

Details

Reviewers

kib
markj

Commits

rGaa182e53e8ed: Disallow invalid PT_GNU_STACK
rG36a757de23ac: Disallow invalid PT_GNU_STACK
rGfbafa98a94cc: Disallow invalid PT_GNU_STACK

Summary

Stack must be at least readable and writable.

PR: 242570

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Jul 20 2022, 4:25 PM

emaste created this revision.

markj accepted this revision.Jul 20 2022, 4:31 PM

This revision is now accepted and ready to land.Jul 20 2022, 4:31 PM

Did you looked at where the reported 'hang' occur? I suspect the actual bug is elsewere. I would expect that copyout_strings() would just error out, could we leak the vnode lock?

I admit I did not look further and have not created a binary with corrupted PT_GNU_STACK [also asked the original submitter in PR, but got no response], but I will try to take a look either before committing this or with it reverted.