Page MenuHomeFreeBSD
Differential D35867

Disallow invalid PT_GNU_STACK
ClosedPublic
Actions

Authored by emaste on Jul 20 2022, 4:25 PM.
Tags
None
Referenced Files
F115710266: D35867.diff
Sun, Apr 27, 12:07 PM
Unknown Object (File)
Fri, Apr 25, 5:26 AM
Unknown Object (File)
Wed, Apr 23, 9:48 PM
Unknown Object (File)
Tue, Apr 22, 2:53 PM
Unknown Object (File)
Mon, Apr 21, 9:11 AM
Unknown Object (File)
Sat, Apr 19, 9:10 PM
Unknown Object (File)
Tue, Apr 15, 9:31 AM
Unknown Object (File)
Tue, Apr 15, 8:21 AM
View All 56 Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rGaa182e53e8ed: Disallow invalid PT_GNU_STACK
rG36a757de23ac: Disallow invalid PT_GNU_STACK
rGfbafa98a94cc: Disallow invalid PT_GNU_STACK
Summary

Stack must be at least readable and writable.

PR: 242570

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste requested review of this revision.Jul 20 2022, 4:25 PM
emaste created this revision.
markj accepted this revision.Jul 20 2022, 4:31 PM
This revision is now accepted and ready to land.Jul 20 2022, 4:31 PM
kib accepted this revision.Jul 20 2022, 4:37 PM

Did you looked at where the reported 'hang' occur? I suspect the actual bug is elsewere. I would expect that copyout_strings() would just error out, could we leak the vnode lock?

emaste added a comment.Jul 20 2022, 4:40 PM

I admit I did not look further and have not created a binary with corrupted PT_GNU_STACK [also asked the original submitter in PR, but got no response], but I will try to take a look either before committing this or with it reverted.

emaste added a comment.Aug 16 2022, 7:52 PM

I will try to take a look either before committing this or with it reverted.

I did not get a chance to do it yet, will eventually try reverting it and continuing to investigate.

Closed by commit rGfbafa98a94cc: Disallow invalid PT_GNU_STACK (authored by emaste). · Explain WhyAug 16 2022, 7:53 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rGfbafa98a94cc: Disallow invalid PT_GNU_STACK.
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2022, 7:53 PM
emaste added a commit: rG36a757de23ac: Disallow invalid PT_GNU_STACK.Sep 5 2022, 12:00 AM
emaste added a commit: rGaa182e53e8ed: Disallow invalid PT_GNU_STACK.

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines

Diff 108371

View Options

sys/kern/imgact_elf.c

Loading...