ddb: use _FLAGS command macros where appropriate
ClosedPublic
Actions

Authored by mhorne on Jun 23 2022, 6:04 PM.

Details

Reviewers

jhb
markj

Commits

rG2571d6f331a4: ddb: use _FLAGS command macros where appropriate
rG258958b3c7e0: ddb: use _FLAGS command macros where appropriate

Summary

Some command definitions were forced to use DB_FUNC in order to specify
their required flags, CS_OWN or CS_MORE. Use the new macros to simplify
these.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46100
Build 42989: arc lint + arc unit

Event Timeline

mhorne created this revision.Jun 23 2022, 6:04 PM

Herald added subscribers: glebius, melifaro, ae and 3 others. · View Herald TranscriptJun 23 2022, 6:04 PM

mhorne requested review of this revision.Jun 23 2022, 6:04 PM

Harbormaster completed remote builds in B46100: Diff 107307.Jun 23 2022, 6:04 PM

mhorne added a parent revision: D35581: ddb: add the DB_CMD_MEMSAFE flag for commands.Jun 23 2022, 6:04 PM

mhorne added a child revision: D35583: ddb: annotate some commands with DB_CMD_MEMSAFE.

mhorne removed a child revision: D35583: ddb: annotate some commands with DB_CMD_MEMSAFE.Jun 23 2022, 6:10 PM

markj accepted this revision.Jun 24 2022, 2:15 PM

This revision is now accepted and ready to land.Jun 24 2022, 2:15 PM

I feel like there's some custom ones in sys/dev/cxgbe as well. They use a custom table though, so maybe that doesn't quite work for this.

Closed by commit rG258958b3c7e0: ddb: use _FLAGS command macros where appropriate (authored by mhorne). · Explain WhyJul 5 2022, 3:09 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG258958b3c7e0: ddb: use _FLAGS command macros where appropriate.

mhorne added a commit: rG2571d6f331a4: ddb: use _FLAGS command macros where appropriate.Aug 11 2022, 2:34 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

gic.c

2 lines

dev/

aic7xxx/

aic79xx_osm.c

2 lines

bxe/

bxe_debug.c

8 lines

gdb/

netgdb.c

2 lines

kern/

kern_sysctl.c

2 lines

net/

route/

route_ddb.c

2 lines

netinet/

netdump/

netdump_client.c

2 lines

x86/

iommu/

intel_drv.c

2 lines

Diff 107307

View Options

sys/arm/arm/gic.c

View Options

sys/dev/aic7xxx/aic79xx_osm.c

View Options

sys/dev/bxe/bxe_debug.c

View Options

sys/gdb/netgdb.c

View Options

sys/kern/kern_sysctl.c

View Options

sys/net/route/route_ddb.c

View Options

sys/netinet/netdump/netdump_client.c

View Options

ddb: use _FLAGS command macros where appropriateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 107307

sys/arm/arm/gic.c

sys/dev/aic7xxx/aic79xx_osm.c

sys/dev/bxe/bxe_debug.c

sys/gdb/netgdb.c

sys/kern/kern_sysctl.c

sys/net/route/route_ddb.c

sys/netinet/netdump/netdump_client.c

sys/x86/iommu/intel_drv.c

ddb: use _FLAGS command macros where appropriate
ClosedPublic
Actions

Revision Contents
Changeset List