aw_wdog: support Allwinner D1 watchdog
ClosedPublic
Actions

Authored by julien.cassette_gmail.com on Apr 2 2022, 11:38 AM.

Details

Reviewers

manu
mhorne

Group Reviewers

riscv

Commits

rGe22111893089: aw_wdog: support Allwinner D1 watchdog
rG3a6f0bb25f06: aw_wdog: support Allwinner D1 watchdog

Summary

Signed-off-by: Julien Cassette <julien.cassette@gmail.com>

Test Plan

The Lichee RV does not reset any more after executing watchdog -t 0

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44963
Build 41851: arc lint + arc unit

Event Timeline

julien.cassette_gmail.com created this revision.Apr 2 2022, 11:38 AM

Herald added a reviewer: manu. · View Herald TranscriptApr 2 2022, 11:38 AM

Herald added subscribers: Contributor Reviews (src), andrew, imp. · View Herald Transcript

julien.cassette_gmail.com requested review of this revision.Apr 2 2022, 11:38 AM

Harbormaster completed remote builds in B44963: Diff 104497.Apr 2 2022, 11:38 AM

julien.cassette_gmail.com added a parent revision: D34748: riscv: add Allwinner D1 device tree.Apr 2 2022, 11:38 AM

julien.cassette_gmail.com added a child revision: D34750: riscv: support Allwinner D1 interrupt controllers.

julien.cassette_gmail.com edited the test plan for this revision. (Show Details)Apr 2 2022, 11:44 AM

julien.cassette_gmail.com added a reviewer: riscv.

julien.cassette_gmail.com edited the test plan for this revision. (Show Details)Apr 2 2022, 11:49 AM

I don't see any reason why this needs to be part of the revision stack, it isn't dependent on anything else

sys/riscv/include/machdep.h
40	For what? You haven't touched this header.

In D34749#787499, @jrtc27 wrote:

I don't see any reason why this needs to be part of the revision stack, it isn't dependent on anything else

Hello Jessica.
Sorry I am a new contributor to FreeBSD and have not used Phabricator before.
If you tell me how I can maybe edit the stack so that the revisions are separate?
Regards, Julien.

julien.cassette_gmail.com added inline comments.Apr 2 2022, 1:05 PM

sys/riscv/include/machdep.h
40	This is to get the definition of `PHYS_AVAIL_ENTRIES`. Otherwise the build would fail.

The driver changes look good to me although I am not the authority there. As mentioned please drop the diff to machdep.h.

In D34749#787518, @julien.cassette_gmail.com wrote:

Hello Jessica.
Sorry I am a new contributor to FreeBSD and have not used Phabricator before.
If you tell me how I can maybe edit the stack so that the revisions are separate?
Regards, Julien.

Check out 'Edit Related Revisions' on the right hand side.

sys/riscv/allwinner/files.allwinner
1–3	This seems fine for now; we can always re-evaluate how this is organized if/when more allwinner drivers get added to the riscv build.
sys/riscv/include/machdep.h
40	I believe we can do away with the problematic `physmap` global altogether. I will handle this separately. For this review, it should be enough to remove `#include <machine/machdep.h>` from the watchdog driver. I could build the arm and arm64 kernels without it.

This revision is now accepted and ready to land.Apr 3 2022, 4:54 PM

Drop machdep.h

This revision now requires review to proceed.Apr 3 2022, 6:38 PM

Harbormaster completed remote builds in B44976: Diff 104535.Apr 3 2022, 6:38 PM

julien.cassette_gmail.com removed a parent revision: D34748: riscv: add Allwinner D1 device tree.Apr 3 2022, 6:39 PM

In D34749#787764, @mhorne wrote:

The driver changes look good to me although I am not the authority there. As mentioned please drop the diff to machdep.h.

Check out 'Edit Related Revisions' on the right hand side.

Hi Mitchell and thanks for the review.
I have made the corrections for machdep.h and removed the parent revision.
Julien