Page MenuHomeFreeBSD

riscv: add Allwinner D1 device tree
AbandonedPublic

Authored by mhorne on Apr 2 2022, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 5:58 PM
Unknown Object (File)
Mon, Jan 6, 10:49 AM
Unknown Object (File)
Nov 29 2024, 12:45 AM
Unknown Object (File)
Nov 29 2024, 12:45 AM
Unknown Object (File)
Nov 29 2024, 12:15 AM
Unknown Object (File)
Nov 19 2024, 7:05 AM
Unknown Object (File)
Nov 18 2024, 5:15 AM
Unknown Object (File)
Nov 4 2024, 8:37 AM

Details

Reviewers
manu
julien.cassette_gmail.com
Group Reviewers
riscv
Summary

Obtained from: https://github.com/smaeul/linux/commit/06b026a8b7148f18356c5f809e51f013c2494587

Signed-off-by: Julien Cassette <julien.cassette@gmail.com>

Test Plan

The DTB files are built.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44962
Build 41850: arc lint + arc unit

Event Timeline

Why do we need this? Device trees should come from the firmware in this day and age...

Why do we need this? Device trees should come from the firmware in this day and age...

Hello Jessica.
Since this is done for other devices, I guessed this was needed for some cases (e.g. maybe the firmware does not always provide the exact DTB we expect?), or even just for documentation purposes.
Regards, Julien.

Why do we need this? Device trees should come from the firmware in this day and age...

Hello Jessica.
Since this is done for other devices, I guessed this was needed for some cases (e.g. maybe the firmware does not always provide the exact DTB we expect?), or even just for documentation purposes.
Regards, Julien.

This was added for the SiFive Unleashed because initially there was no proper firmware, U-Boot came later and instead you just had to direct boot a kernel. There is no need for it any more even there.

Why do we need this? Device trees should come from the firmware in this day and age...

Hello Jessica.
Since this is done for other devices, I guessed this was needed for some cases (e.g. maybe the firmware does not always provide the exact DTB we expect?), or even just for documentation purposes.
Regards, Julien.

This was added for the SiFive Unleashed because initially there was no proper firmware, U-Boot came later and instead you just had to direct boot a kernel. There is no need for it any more even there.

Okay, thanks for the explanation. I guess we can drop the review then.

There is no need for it any more even there.

Shall we remove it to avoid any confusion? Presumably we are no longer interested in supporting SiFive Unleashed cases without uboot.

Why do we need this? Device trees should come from the firmware in this day and age...

The headers are still needed, I guess I need to update the vendor import.

Note that sun20i-d1-msgbox.h is listed as GPL-only

bcr added a subscriber: bcr.

Remove core-team, as we do not seem to get involved in this.

mhorne abandoned this revision.

Closing this, as the DTS sources are now present in the tree, imported from Linux.

The logic to build and distribute the DTB may be added as a future step, but it is not currently required as we rely on the DTB from u-boot.