Page MenuHomeFreeBSD

Fix the spelling of EFI_PAGE_SIZE
ClosedPublic

Authored by andrew on Mar 9 2022, 6:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 5:22 PM
Unknown Object (File)
Fri, Oct 25, 1:02 AM
Unknown Object (File)
Sun, Oct 20, 1:42 PM
Unknown Object (File)
Sep 22 2024, 5:32 PM
Unknown Object (File)
Sep 18 2024, 2:26 PM
Unknown Object (File)
Sep 18 2024, 6:54 AM
Unknown Object (File)
Sep 18 2024, 1:35 AM
Unknown Object (File)
Sep 16 2024, 6:48 PM
Subscribers

Details

Summary

We assume EFI_PAGE_SIZE is the same as PAGE_SIZE, however this may not
be the case. Use the former when working with a list of pages from the
UEFI firmware so the correct size is used.

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Mar 9 2022, 6:42 PM

These look good... but where's EFI_PAGE_SIZE defined? And does it need to be a run-time thing?
It's a good fix, but I'd like to understand the larger context :)

This revision is now accepted and ready to land.Mar 9 2022, 7:20 PM
In D34510#781812, @imp wrote:

These look good... but where's EFI_PAGE_SIZE defined? And does it need to be a run-time thing?
It's a good fix, but I'd like to understand the larger context :)

AFAIK the spec doesn't allow any flexibility here, every arch is forced to 4k pages to be compliant (see various mmu configuration verbiages in "Calling Conventions")

In D34510#781812, @imp wrote:

These look good... but where's EFI_PAGE_SIZE defined? And does it need to be a run-time thing?
It's a good fix, but I'd like to understand the larger context :)

AFAIK the spec doesn't allow any flexibility here, every arch is forced to 4k pages to be compliant (see various mmu configuration verbiages in "Calling Conventions")

oh! It's so *OUR* PAGE_SIZE to change.... :) Thanks for the pointers... my brain glossed over them before....

This revision was automatically updated to reflect the committed changes.