Page MenuHomeFreeBSD

budsma: fix boundary alignment test
ClosedPublic

Authored by dougm on Jan 1 2022, 11:48 PM.
Tags
None
Referenced Files
F95868641: D33715.diff
Sun, Sep 22, 9:23 PM
Unknown Object (File)
Sat, Sep 21, 12:31 PM
Unknown Object (File)
Sat, Sep 21, 12:31 PM
Unknown Object (File)
Sat, Sep 21, 12:30 PM
Unknown Object (File)
Sat, Sep 21, 12:17 PM
Unknown Object (File)
Wed, Sep 18, 2:33 PM
Unknown Object (File)
Tue, Sep 17, 6:26 PM
Unknown Object (File)
Tue, Sep 17, 3:21 PM

Details

Summary

c606ab59e7f9 vm_extern: use standard address checkers everywhere

broke a check in _bus_dmamap_addseg on many architectures. This change makes it clear that it is not a particular range that is being boundary-checked, but the proposed union of the two adjacent ranges.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Jan 1 2022, 11:48 PM

Looks good to me:

increase current segment by sgsize bytes if

  • curraddr is contiguous to the end of the segment,
  • adding sgsize will not cause maxsegsz to be exceeded, and
  • start address plus increased segment length will still pass the boundary check.
This revision is now accepted and ready to land.Jan 2 2022, 1:23 PM
This revision was automatically updated to reflect the committed changes.