arm64: Reduce the use of DMAMAP_COHERENT
Needs ReviewPublic
Actions

Authored by andrew on Fri, Mar 28, 5:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 25, 11:17 AM

	Unknown Object (File)
	Tue, Apr 22, 1:43 PM

	Unknown Object (File)
	Thu, Apr 17, 2:46 AM

	Unknown Object (File)
	Tue, Apr 8, 3:05 AM

	Unknown Object (File)
	Tue, Apr 8, 3:05 AM

	Unknown Object (File)
	Sun, Apr 6, 1:03 PM

	Unknown Object (File)
	Sat, Apr 5, 6:38 AM

	Unknown Object (File)
	Sat, Apr 5, 12:09 AM

Subscribers

Details

Reviewers

manu

Group Reviewers

arm64

Summary

The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63184
Build 60068: arc lint + arc unit

andrew requested review of this revision.Fri, Mar 28, 5:16 PM

ehem_freebsd_m5p.com added inline comments.

sys/arm64/arm64/busdma_bounce.c
105	Why is `DMAMAP_COHERENT` being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new `#define` below so this doesn't seem useful as you've got a halfway done job.
364–368	Since both of these are now single-line, I would remove the brackets while you're at it.