Page MenuHomeFreeBSD
Differential D49559

arm64: Reduce the use of DMAMAP_COHERENT
Needs ReviewPublic
Actions

Authored by andrew on Fri, Mar 28, 5:16 PM.
Tags
None
Referenced Files
F113867941: D49559.id.diff
Fri, Apr 4, 8:31 PM
F113848057: D49559.diff
Fri, Apr 4, 12:51 PM
Unknown Object (File)
Tue, Apr 1, 2:52 AM
Subscribers
ehem_freebsd_m5p.com
emaste
imp

Details

Reviewers
manu
Group Reviewers
arm64
Summary

The coherent busdma implementation doesn't need to set DMAMAP_COHERENT.
It is only used in cacheline_bounce which is unused there.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 63184
Build 60068: arc lint + arc unit

Event Timeline

andrew created this revision.Fri, Mar 28, 5:16 PM
Herald added a reviewer: manu. · View Herald TranscriptFri, Mar 28, 5:16 PM
Herald added subscribers: emaste, imp. · View Herald Transcript
andrew requested review of this revision.Fri, Mar 28, 5:16 PM
Harbormaster completed remote builds in B63184: Diff 152802.Fri, Mar 28, 5:16 PM
andrew added a parent revision: D49558: arm64: Move cacheline_bounce later.Fri, Mar 28, 5:16 PM
ehem_freebsd_m5p.com added a subscriber: ehem_freebsd_m5p.com.Fri, Mar 28, 11:20 PM
ehem_freebsd_m5p.com added inline comments.
sys/arm64/arm64/busdma_bounce.c
105

Why is DMAMAP_COHERENT being renamed here? This seems an okay idea, but if you're going to rename all the other uses should also be modified. Yet instead you have the new #define below so this doesn't seem useful as you've got a halfway done job.

364–368

Since both of these are now single-line, I would remove the brackets while you're at it.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
5 lines
13 lines

Diff 152802

View Options

sys/arm64/arm64/busdma_bounce.h

Loading...
View Options

sys/arm64/arm64/busdma_bounce.c

Loading...