Page MenuHomeFreeBSD

budsma: fix boundary alignment test
ClosedPublic

Authored by dougm on Jan 1 2022, 11:48 PM.
Tags
None
Referenced Files
F102364460: D33715.id100835.diff
Mon, Nov 11, 6:32 AM
F102356127: D33715.id100812.diff
Mon, Nov 11, 3:53 AM
F102355737: D33715.id100812.diff
Mon, Nov 11, 3:45 AM
F102354685: D33715.id.diff
Mon, Nov 11, 3:24 AM
F102353853: D33715.diff
Mon, Nov 11, 3:06 AM
Unknown Object (File)
Sun, Nov 10, 8:07 PM
Unknown Object (File)
Sep 30 2024, 7:58 AM
Unknown Object (File)
Sep 27 2024, 6:18 AM

Details

Summary

c606ab59e7f9 vm_extern: use standard address checkers everywhere

broke a check in _bus_dmamap_addseg on many architectures. This change makes it clear that it is not a particular range that is being boundary-checked, but the proposed union of the two adjacent ranges.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Jan 1 2022, 11:48 PM

Looks good to me:

increase current segment by sgsize bytes if

  • curraddr is contiguous to the end of the segment,
  • adding sgsize will not cause maxsegsz to be exceeded, and
  • start address plus increased segment length will still pass the boundary check.
This revision is now accepted and ready to land.Jan 2 2022, 1:23 PM
This revision was automatically updated to reflect the committed changes.