Paths

Table of Contentst

Differential D33703

exec: Simplify sv_copyout_strings implementations a bit
ClosedPublic
Actions

Authored by markj on Dec 30 2021, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 25, 4:58 PM

	Unknown Object (File)
	Thu, Apr 24, 12:54 AM

	Unknown Object (File)
	Thu, Apr 24, 12:54 AM

	Unknown Object (File)
	Sun, Apr 20, 2:51 PM

	Unknown Object (File)
	Sun, Apr 6, 2:53 PM

	Unknown Object (File)
	Mar 22 2025, 1:44 AM

	Unknown Object (File)
	Mar 19 2025, 3:52 AM

	Unknown Object (File)
	Mar 9 2025, 10:42 AM

Subscribers

Details

Reviewers

mw
emaste
kib
dgr_semihalf.com
manu

Commits

rGf04a09604938: exec: Simplify sv_copyout_strings implementations a bit

Summary

Simplify control flow around handling of the execpath length and signal
trampoline. Cache the sysentvec pointer in a local variable.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 30 2021, 10:41 PM

Herald added a reviewer: manu. · View Herald TranscriptDec 30 2021, 10:41 PM

Herald added subscribers: andrew, imp. · View Herald Transcript

markj requested review of this revision.Dec 30 2021, 10:41 PM

Harbormaster completed remote builds in B43653: Diff 100768.Dec 30 2021, 10:41 PM

markj added a child revision: D33704: Rework the stack gap implementation.Dec 30 2021, 10:41 PM

kib accepted this revision.Dec 31 2021, 12:40 AM

kib added inline comments.

sys/kern/kern_exec.c
1634–1635	I suspect this code can be removed, but lets keep it for now. This variant is only for ABIs without shared page, and I think native FreeBSD ABI uses shared page on all arches.
1676–1677	szps can be eliminated. Initialize imgp->pagesizelen in place of szps, and substract it from destp

This revision is now accepted and ready to land.Dec 31 2021, 12:40 AM

emaste added inline comments.Dec 31 2021, 1:07 AM

sys/kern/kern_exec.c
1634–1635	That is these conditions could become `KASSERT`s in the future?

kib added inline comments.Dec 31 2021, 2:16 AM

sys/kern/kern_exec.c
1634–1635	It would naturally traps on NULL access.

Eliminate szps.

This revision now requires review to proceed.Dec 31 2021, 3:21 AM

Harbormaster completed remote builds in B43657: Diff 100781.Dec 31 2021, 3:21 AM

kib accepted this revision.Dec 31 2021, 4:03 PM

This revision is now accepted and ready to land.Dec 31 2021, 4:03 PM

Closed by commit rGf04a09604938: exec: Simplify sv_copyout_strings implementations a bit (authored by markj). · Explain WhyDec 31 2021, 6:09 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGf04a09604938: exec: Simplify sv_copyout_strings implementations a bit.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

linux/

9 lines

linux32/

linux32_sysvec.c

9 lines

arm64/

linux/

9 lines

compat/

freebsd32/

freebsd32_misc.c

28 lines

i386/

linux/

8 lines

kern/

40 lines

Diff 100790

sys/amd64/linux/linux_sysvec.c

Loading...

sys/amd64/linux32/linux32_sysvec.c

Loading...

sys/arm64/linux/linux_sysvec.c

Loading...

sys/compat/freebsd32/freebsd32_misc.c

Loading...

sys/i386/linux/linux_sysvec.c

Loading...

sys/kern/kern_exec.c

Loading...