Page MenuHomeFreeBSD

csu: define STRIP_FBSDID
ClosedPublic

Authored by emaste on Dec 20 2021, 9:38 PM.
Tags
None
Referenced Files
F102925101: D33594.id100376.diff
Mon, Nov 18, 7:50 PM
Unknown Object (File)
Sat, Nov 16, 7:19 AM
Unknown Object (File)
Wed, Nov 13, 1:07 PM
Unknown Object (File)
Mon, Nov 11, 6:20 AM
Unknown Object (File)
Tue, Oct 22, 7:53 PM
Unknown Object (File)
Oct 20 2024, 2:07 AM
Unknown Object (File)
Oct 7 2024, 2:26 PM
Unknown Object (File)
Oct 3 2024, 12:33 PM

Details

Summary

__FBSDID() places the provided string in the output object's .comment section. However, with the transition to Git $FreeBSD$ is no longer expanded and so we emitted a literal $FreeBSD$.

$FreeBSD$ will be addressed in a holistic manner in the future, but for now define STRIP_FBSDID to at least avoid having it embedded into everything linked on FreeBSD (via csu).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.

Why not define STRIP_FBSDID globally, reusing the same argument?

This revision was not accepted when it landed; it landed in state Needs Review.Dec 21 2021, 6:35 PM
This revision was automatically updated to reflect the committed changes.

Why not define STRIP_FBSDID globally, reusing the same argument?

Yes, although perhaps change the sense and make it EMBED_FBSDID instead?

Oops, I did not intend to push this to main yet. I will open another review for an alternate approach.