Page MenuHomeFreeBSD

MFC r368649 / 3fd989da by kib: amd64 pmap: fix PCID mode invalidations
ClosedPublic

Authored by avg on Dec 13 2021, 12:40 PM.
Tags
None
Referenced Files
F115953973: D33413.diff
Wed, Apr 30, 8:12 PM
Unknown Object (File)
Wed, Apr 23, 7:54 AM
Unknown Object (File)
Tue, Apr 22, 9:14 PM
Unknown Object (File)
Tue, Apr 22, 6:01 AM
Unknown Object (File)
Tue, Apr 22, 5:32 AM
Unknown Object (File)
Thu, Apr 17, 4:20 AM
Unknown Object (File)
Thu, Apr 17, 2:14 AM
Unknown Object (File)
Mar 13 2025, 12:30 AM
Subscribers

Details

Summary

r368649 fixed a regression in r362031 that was MFC-ed to stable/12 as
a part of r362572. That commit reordered IPI send and local TLB flush in
TLB invalidations.

Without this fix we've been seeing problems with stale memory content
where changes done under a mutex were not immediately observed by
another thread after taking the same mutex. Those inconsistenices were
correlated to copy-on-write faults for pages contaning the data.

The change needed some adaptations as I elected to skip two significant
intermediate changes:

  • r363195 / dc43978a, amd64: allow parallel shootdown IPIs
  • r363311 / 3ec7e169, amd64 pmap: microoptimize local shootdowns for PCID PTI configurations

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43310
Build 40198: arc lint + arc unit

Event Timeline

avg requested review of this revision.Dec 13 2021, 12:40 PM
This revision is now accepted and ready to land.Dec 13 2021, 1:39 PM

Do we want to make this an EN for 12.3 as well?

Do we want to make this an EN for 12.3 as well?

I think that some people may appreciate it, especially if the Go deadlocks / crashes also have the same root cause.