crypto: Validate AES-GCM IV length in check_csp().
ClosedPublic
Actions

Authored by jhb on Nov 30 2021, 5:17 PM.

Details

Reviewers

Commits

rGa41ff1661bc0: crypto: Validate AES-GCM IV length in check_csp().
rG6e17a2e00d62: crypto: Validate AES-GCM IV length in check_csp().

Summary

This centralizes the check for valid nonce lengths for AES-GCM.

While here, remove some duplicate checks for valid AES-GCM tag lengths
from ccp(4) and ccr(4).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Nov 30 2021, 5:17 PM

Herald added subscribers: ae, jmg, andrew, imp. · View Herald TranscriptNov 30 2021, 5:17 PM

jhb requested review of this revision.Nov 30 2021, 5:17 PM

Harbormaster completed remote builds in B43058: Diff 99247.Nov 30 2021, 5:17 PM

jhb added a child revision: D33195: cryptosoft: Reject AES-CCM/GCM sessions with invalid key lengths..Nov 30 2021, 5:18 PM

markj accepted this revision.Nov 30 2021, 5:42 PM

markj added inline comments.

sys/opencrypto/crypto.c
854–857	Should we s/16/AES_GMAC_HASH_LEN/?

This revision is now accepted and ready to land.Nov 30 2021, 5:42 PM

jhb marked an inline comment as done.Dec 4 2021, 12:10 AM

Closed by commit rG6e17a2e00d62: crypto: Validate AES-GCM IV length in check_csp(). (authored by jhb). · Explain WhyDec 9 2021, 8:18 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG6e17a2e00d62: crypto: Validate AES-GCM IV length in check_csp()..

jhb added a commit: rGa41ff1661bc0: crypto: Validate AES-GCM IV length in check_csp()..Apr 29 2022, 8:55 PM

Revision Contents
Changeset List

Path

Size

sys/

crypto/

aesni/

aesni.c

3 lines

armv8/

armv8_crypto.c

2 lines

ccp/

ccp.c

5 lines

dev/

cxgbe/

crypto/

t4_crypto.c

6 lines

qat/

qat.c

2 lines

safexcel/

safexcel.c

3 lines

opencrypto/

crypto.c

5 lines

cryptosoft.c

3 lines

Diff 99777

View Options

sys/crypto/aesni/aesni.c

View Options

sys/crypto/armv8/armv8_crypto.c

View Options

sys/crypto/ccp/ccp.c

View Options

sys/dev/cxgbe/crypto/t4_crypto.c

View Options

sys/dev/qat/qat.c

View Options

sys/dev/safexcel/safexcel.c

View Options

sys/opencrypto/crypto.c

View Options

sys/opencrypto/cryptosoft.c

crypto: Validate AES-GCM IV length in check_csp().ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 99777

sys/crypto/aesni/aesni.c

sys/crypto/armv8/armv8_crypto.c

sys/crypto/ccp/ccp.c

sys/dev/cxgbe/crypto/t4_crypto.c

sys/dev/qat/qat.c

sys/dev/safexcel/safexcel.c

sys/opencrypto/crypto.c

sys/opencrypto/cryptosoft.c

crypto: Validate AES-GCM IV length in check_csp().
ClosedPublic
Actions

Revision Contents
Changeset List