Page MenuHomeFreeBSD

cryptosoft: Stop single-threading requests within a session.
ClosedPublic

Authored by jhb on Dec 7 2021, 12:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 23, 2:01 AM
Unknown Object (File)
Fri, Sep 20, 1:02 AM
Unknown Object (File)
Thu, Sep 19, 7:42 PM
Unknown Object (File)
Thu, Sep 19, 11:10 AM
Unknown Object (File)
Wed, Sep 18, 10:50 PM
Unknown Object (File)
Wed, Sep 18, 10:25 AM
Unknown Object (File)
Tue, Sep 17, 5:01 PM
Unknown Object (File)
Tue, Sep 17, 1:22 PM
Subscribers

Details

Summary

All of the request handlers no longer modify session state, so remove
the mutex limiting operations to one per session. In addition, change
the pointer to the session state passed to process callbacks to const.

Suggested by: mjg
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Dec 7 2021, 12:37 AM
markj added inline comments.
sys/opencrypto/cryptosoft.c
79

No need to break the line, I think.

910

I think this can stay as one line.

This revision is now accepted and ready to land.Dec 7 2021, 1:18 AM
sys/opencrypto/cryptosoft.c
79

I think it crossed 80 cols in my editor, but I'll double check.

Thank you!

Is this mfcable to stable/12 by any chance?

In D33317#754176, @mjg wrote:

Thank you!

Is this mfcable to stable/12 by any chance?

Hmmm, I can maybe see about merging to 13. OCF in 12 is quite a bit different. It could perhaps be reimplemented there, but there might be quite a few conflicts.

In that case I would not bother.

jhb marked 2 inline comments as done.Dec 9 2021, 7:28 PM