Paths

Table of Contentst

Differential D33079

Per-thread stack canary on arm64
ClosedPublic
Actions

Authored by andrew on Nov 22 2021, 4:38 PM.

Tags

None

Referenced Files

	F102639154: D33079.diff
	Fri, Nov 15, 4:47 AM

	Unknown Object (File)
	Oct 9 2024, 12:36 AM

	Unknown Object (File)
	Oct 1 2024, 11:18 AM

	Unknown Object (File)
	Sep 24 2024, 2:39 AM

	Unknown Object (File)
	Sep 24 2024, 2:39 AM

	Unknown Object (File)
	Sep 15 2024, 5:16 AM

	Unknown Object (File)
	Sep 5 2024, 3:36 AM

	Unknown Object (File)
	Sep 1 2024, 10:52 PM

View All 53 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rGb5346307ed34: Per-thread stack canary on arm64
rGae92ace05fd4: Per-thread stack canary on arm64

Summary

With the update to llvm 13 we are able to tell the compiler it can find
the SSP canary relative to the register that holds the userspace stack
pointer. As this is unused in most of the kernel it can be used here
to point to a per-thread SSP canary.

As the kernel could be built with an old toolchain, e.g. when upgrading
from 13, add a warning that the options was enabled but the compiler
doesn't support it to both the build and kernel boot.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42918
Build 39806: arc lint + arc unit

Event Timeline

andrew created this revision.Nov 22 2021, 4:38 PM

Herald added a reviewer: manu. · View Herald TranscriptNov 22 2021, 4:38 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Nov 22 2021, 4:38 PM

Harbormaster completed remote builds in B42918: Diff 98839.Nov 22 2021, 4:38 PM

emaste added inline comments.Nov 22 2021, 4:43 PM

sys/conf/Makefile.arm64
35	`perthread-ssp` in `COMPILER_FEATURES` perhaps?

andrew added inline comments.Nov 22 2021, 4:56 PM

sys/conf/Makefile.arm64
35	We could although it's not something userspace could use as `sp_el0` is only available to the kernel & hypervisor.

emaste added inline comments.Nov 26 2021, 1:12 AM

sys/conf/Makefile.arm64
35	Yeah, I guess this is fine

This revision was not accepted when it landed; it landed in state Needs Review.Nov 26 2021, 2:51 PM

Closed by commit rGae92ace05fd4: Per-thread stack canary on arm64 (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGae92ace05fd4: Per-thread stack canary on arm64.

andrew added a commit: rGb5346307ed34: Per-thread stack canary on arm64.Dec 20 2021, 2:02 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

arm64/

7 lines

1 line

14 lines

22 lines

4 lines

10 lines

conf/

1 line

include/

1 line

conf/

14 lines

4 lines

Diff 98839

sys/arm64/arm64/exception.S

Loading...

sys/arm64/arm64/genassym.c

Loading...

sys/arm64/arm64/locore.S

Loading...

sys/arm64/arm64/machdep.c

Loading...

sys/arm64/arm64/pmap.c

Loading...

sys/arm64/arm64/vm_machdep.c

Loading...

sys/arm64/conf/std.arm64

Loading...

sys/arm64/include/proc.h

Loading...

sys/conf/Makefile.arm64

Loading...

sys/conf/options.arm64

Loading...