Only demote when needed in the arm64 pmap_change_props_locked
ClosedPublic
Actions

Authored by andrew on Oct 6 2021, 4:46 PM.

Details

Reviewers

alc
kib
markj
manu

Group Reviewers

arm64

Commits

rG39dbb494404f: Only demote when needed in the arm64 pmap_change_props_locked
rG806a88e74200: Only demote when needed in the arm64 pmap_change_props_locked

Summary

When changing page table properties there is no need to demote a
level 1 or level 2 block if we are changing the entire memory range the
block is mapping. In this case just change the block directly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 42000
Build 38888: arc lint + arc unit

Event Timeline

andrew created this revision.Oct 6 2021, 4:46 PM

Herald added a reviewer: manu. · View Herald TranscriptOct 6 2021, 4:46 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Oct 6 2021, 4:46 PM

Harbormaster completed remote builds in B41986: Diff 96352.Oct 6 2021, 4:47 PM

alc added inline comments.Oct 7 2021, 7:47 AM

sys/arm64/arm64/pmap.c
6113	L3_SIZE -> pte_size?

Fix the size in cpu_dcache_wbinv_range

Harbormaster completed remote builds in B42000: Diff 96405.Oct 7 2021, 10:20 AM

markj accepted this revision.Oct 7 2021, 4:09 PM

markj added inline comments.

sys/arm64/arm64/pmap.c
6072	We should have an explicit /* FALLTHROUGH */ annotation here and below.

This revision is now accepted and ready to land.Oct 7 2021, 4:09 PM

alc accepted this revision.Oct 8 2021, 6:51 AM

kib accepted this revision.Oct 8 2021, 10:31 AM

Closed by commit rG806a88e74200: Only demote when needed in the arm64 pmap_change_props_locked (authored by andrew). · Explain WhyOct 11 2021, 10:44 AM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG806a88e74200: Only demote when needed in the arm64 pmap_change_props_locked.

andrew added a commit: rG39dbb494404f: Only demote when needed in the arm64 pmap_change_props_locked.Oct 25 2021, 1:55 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

pmap.c

74 lines

Diff 96405

View Options

Only demote when needed in the arm64 pmap_change_props_lockedClosedPublicActions