Page MenuHomeFreeBSD
Differential D31991

minidump: Use provided msgbuf pointer
ClosedPublic
Actions

Authored by mhorne on Sep 16 2021, 6:40 PM.
Tags
None
Referenced Files
F115008122: D31991.diff
Sat, Apr 19, 1:31 PM
Unknown Object (File)
Fri, Apr 18, 8:59 PM
Unknown Object (File)
Fri, Apr 18, 8:47 PM
Unknown Object (File)
Wed, Apr 16, 7:46 PM
Unknown Object (File)
Sun, Apr 6, 1:09 AM
Unknown Object (File)
Sat, Mar 29, 11:46 PM
Unknown Object (File)
Mar 10 2025, 6:33 AM
Unknown Object (File)
Mar 10 2025, 5:43 AM
View All 68 Files
Subscribers
allanjude
andrew
emaste
imp
jhibbits

Details

Reviewers
manu
markj
kib
jhb
stevek
Commits
rG069d7fa63b21: minidump: Use provided msgbuf pointer
rG1d2d1418b492: minidump: Use provided msgbuf pointer
Summary

Don't assume we are dumping the global message buffer, but use the one
provided by the minidumpstate argument.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mhorne created this revision.Sep 16 2021, 6:40 PM
Herald added a reviewer: manu. · View Herald TranscriptSep 16 2021, 6:40 PM
Herald added subscribers: Contributor Reviews (src), jhibbits, emaste and 2 others. · View Herald Transcript
mhorne requested review of this revision.Sep 16 2021, 6:40 PM
Harbormaster completed remote builds in B41549: Diff 95262.Sep 16 2021, 6:40 PM
mhorne added a parent revision: D31990: minidump: reduce the amount direct accesses to page tables.Sep 16 2021, 6:40 PM
mhorne added a child revision: D31992: minidump: Use the provided dump bitset.
mhorne added reviewers: markj, kib, jhb, stevek.Sep 16 2021, 6:43 PM
mhorne added a parent revision: D31989: minidump: Parameterize minidumpsys().
mhorne edited subscribers, added: allanjude; removed: Contributor Reviews (src).
mhorne added a child revision: D31993: Allow minidumps to be performed on the live system.Sep 16 2021, 6:45 PM
markj accepted this revision.Sep 16 2021, 6:56 PM
markj added inline comments.
sys/amd64/amd64/minidump_machdep.c
304

While here, the casts to (char *) can be dropped.

This revision is now accepted and ready to land.Sep 16 2021, 6:56 PM
jhb accepted this revision.Sep 16 2021, 7:50 PM
Closed by commit rG1d2d1418b492: minidump: Use provided msgbuf pointer (authored by mhorne). · Explain WhyNov 19 2021, 7:07 PM
This revision was automatically updated to reflect the committed changes.
mhorne added a commit: rG1d2d1418b492: minidump: Use provided msgbuf pointer.
mhorne added a commit: rG069d7fa63b21: minidump: Use provided msgbuf pointer.Dec 3 2021, 2:54 PM

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
8 lines
arm/
arm/
9 lines
arm64/
arm64/
9 lines
i386/
i386/
9 lines
mips/
mips/
9 lines
powerpc/
powerpc/
11 lines
riscv/
riscv/
9 lines

Diff 98759

View Options

sys/amd64/amd64/minidump_machdep.c

Loading...
View Options

sys/arm/arm/minidump_machdep.c

Loading...
View Options

sys/arm64/arm64/minidump_machdep.c

Loading...
View Options

sys/i386/i386/minidump_machdep_base.c

Loading...
View Options

sys/mips/mips/minidump_machdep.c

Loading...
View Options

sys/powerpc/powerpc/minidump_machdep.c

Loading...
View Options

sys/riscv/riscv/minidump_machdep.c

Loading...