Differential D31716

sys: Nuke double-semicolons
ClosedPublic
Actions

Authored by ehem_freebsd_m5p.com on Aug 29 2021, 10:08 PM.

Tags

None

Referenced Files

	F102706019: D31716.diff
	Sat, Nov 16, 3:19 AM

	Unknown Object (File)
	Sep 28 2024, 5:27 AM

	Unknown Object (File)
	Sep 28 2024, 5:19 AM

	Unknown Object (File)
	Sep 23 2024, 12:15 PM

	Unknown Object (File)
	Sep 20 2024, 2:18 PM

	Unknown Object (File)
	Sep 16 2024, 11:48 PM

	Unknown Object (File)
	Sep 12 2024, 12:24 AM

	Unknown Object (File)
	Sep 7 2024, 4:23 PM

View All 74 Files

Subscribers

View All 11 Subscribers

Details

Reviewers

manu
emaste
rrs

Group Reviewers

transport
Restricted Owners Package	(Owns No Changed Paths)

Commits

rG21cc0918c779: sys: Nuke double-semicolons

Summary

A distinct number of double-semicolons have ended up in FreeBSD. Take a
pass at getting rid of many of these harmless typos.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41261
Build 38150: arc lint + arc unit

Event Timeline

ehem_freebsd_m5p.com created this revision.Aug 29 2021, 10:08 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 29 2021, 10:08 PM

Herald added a reviewer: transport. · View Herald Transcript

Herald added subscribers: Contributor Reviews (src), donner, melifaro and 5 others. · View Herald Transcript

ehem_freebsd_m5p.com requested review of this revision.Aug 29 2021, 10:08 PM

Harbormaster completed remote builds in B41255: Diff 94337.Aug 29 2021, 10:08 PM

Please don't do the pms ones. That's vendor code that needs to be moved to contrib/sys.

The rest look good to me.

Pulling the hunks from sys/dev/pms/RefTisa. Those did look kind of odd.

Harbormaster completed remote builds in B41261: Diff 94347.Aug 29 2021, 11:33 PM

Pulling one hunk in light of 0637070b5bc, which seems a bit odd.

Harbormaster completed remote builds in B41273: Diff 94397.Aug 30 2021, 9:43 PM

Pulling one hunk in light of 0637070b5bc, which seems a bit odd.

That one was sitting in a local tree for some time, waiting on replies from maintainers or upstreams.
(same case for 8fa63f44e64ebac444a4ac6451ac5e150cdcf8b1, b1a217a369186dc45c7df7bde13a87868fd5b2c8, 11224884f285481ccecb61f57381b51661d77c6d)

emaste accepted this revision.Aug 30 2021, 9:55 PM

rrs added a subscriber: rrs.Oct 26 2021, 5:49 PM

rrs added inline comments.

sys/netinet/sctp_timer.c
332	Make sure to make Michael Tuexen aware of this change since you are changing here not the code of SCTP, thats in a different git repo and has a bunch of undef scrubbers that run on it before submitting to freebsd... so he will need to pull in these changes to the sctp git repo

tuexen added a subscriber: tuexen.Oct 26 2021, 7:53 PM

tuexen added inline comments.

sys/netinet/sctp_timer.c
332	I committed this already to the FreeBSD tree and also to the upstream repositories in 454216468583481746845a1c8a45a8c18898ee72

rrs accepted this revision.Feb 10 2022, 3:22 PM

This revision is now accepted and ready to land.Feb 10 2022, 3:22 PM

Herald added a subscriber: glebius. · View Herald TranscriptFeb 10 2022, 3:22 PM

Closed by commit rG21cc0918c779: sys: Nuke double-semicolons (authored by ehem_freebsd_m5p.com, committed by imp). · Explain WhyNov 2 2022, 3:36 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG21cc0918c779: sys: Nuke double-semicolons.

Owners added a reviewer: Restricted Owners Package.Nov 2 2022, 3:36 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

mv/

2 lines

arm64/

nvidia/

tegra210/

2 lines

compat/

linux/

2 lines

contrib/

ngatm/

netnatm/

sig/

2 lines

dev/

axgbe/

2 lines

e1000/

2 lines

ena/

2 lines

etherswitch/

felix/

2 lines

fdt/

2 lines

netmap/

2 lines

ocs_fc/

2 lines

vmd/

2 lines

netinet/

4 lines

netinet6/

2 lines

netpfil/

ipfw/

2 lines

sys/

2 lines

Diff 94347

sys/arm/mv/mv_ap806_sei.c

Loading...

sys/arm64/nvidia/tegra210/max77620.c

Loading...

sys/compat/linux/linux_ioctl.c

Loading...

sys/contrib/ngatm/netnatm/sig/sig_party.c

Loading...

sys/dev/axgbe/if_axgbe_pci.c

Loading...

sys/dev/e1000/if_em.c

Loading...

sys/dev/ena/ena.c

Loading...

sys/dev/etherswitch/felix/felix.c

Loading...

sys/dev/fdt/simple_mfd.c

Loading...

sys/dev/netmap/netmap_kern.h

Loading...

sys/dev/ocs_fc/ocs_domain.h

Loading...

sys/dev/vmd/vmd.c

Loading...

sys/netinet/sctp_timer.c

Loading...

sys/netinet6/ip6_output.c

Loading...

sys/netpfil/ipfw/dn_aqm_codel.h

Loading...

sys/sys/unpcb.h

Loading...