Page MenuHomeFreeBSD
Differential D31552

linux(4): Consolidate wait* facility into linux_common_wait().
ClosedPublic
Actions

Authored by dchagin on Aug 16 2021, 12:07 PM.
Tags
None
Referenced Files
F115402694: D31552.id104409.diff
Wed, Apr 23, 10:50 AM
Unknown Object (File)
Tue, Apr 22, 12:22 AM
Unknown Object (File)
Sun, Apr 20, 8:20 AM
Unknown Object (File)
Wed, Apr 16, 10:56 AM
Unknown Object (File)
Fri, Apr 11, 2:52 AM
Unknown Object (File)
Sun, Apr 6, 5:35 PM
Unknown Object (File)
Mar 11 2025, 9:59 PM
Unknown Object (File)
Mar 11 2025, 3:39 AM
View All 77 Files
Subscribers
andrew
emaste
imp
kib
pauamma_gundo.com

Details

Reviewers
manu
brooks
Group Reviewers
Linux Emulation
manpages
Commits
rG721dcd87abe3: linux(4): Consolidate wait* facility into linux_common_wait().
rG0c6b1ff7de56: linux(4): Consolidate wait* facility into linux_common_wait().
Summary

Also this fixes bug in waitid() implementation, use wru_self not wru_children.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44921
Build 41809: arc lint + arc unit

Event Timeline

dchagin created this revision.Aug 16 2021, 12:07 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 16 2021, 12:07 PM
Harbormaster completed remote builds in B41057: Diff 93742.Aug 16 2021, 12:07 PM
dchagin requested review of this revision.Aug 16 2021, 12:07 PM
dchagin added a reviewer: Linux Emulation.Aug 16 2021, 12:17 PM
dchagin changed the repository for this revision from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
dchagin updated this revision to Diff 93777.Aug 16 2021, 7:01 PM

style(9)

Harbormaster completed remote builds in B41079: Diff 93777.Aug 16 2021, 7:01 PM
dchagin added a child revision: D31561: linux(4): Fixup wait4 handling pid equal 0 case..Aug 23 2021, 4:23 PM
dchagin mentioned this in D31561: linux(4): Fixup wait4 handling pid equal 0 case..
kib added a subscriber: kib.Sep 5 2021, 12:31 AM
kib added inline comments.
sys/compat/linux/linux_misc.c
1008

What is the point of mallocing them? The structures are not that large to not fit into stack for top-level.

1029

Same question about mallocing this one.

dchagin updated this revision to Diff 104235.Mar 26 2022, 5:26 PM

indeed, back to stack allocation of local vars.

Harbormaster completed remote builds in B44897: Diff 104235.Mar 26 2022, 5:26 PM
dchagin updated this revision to Diff 104343.Mar 29 2022, 8:47 PM

fix, add D31561 code

Herald added a reviewer: manu. · View Herald TranscriptMar 29 2022, 8:47 PM
Herald added a reviewer: brooks. · View Herald Transcript
Herald added a reviewer: manpages. · View Herald Transcript
Herald added subscribers: emaste, andrew. · View Herald Transcript
Harbormaster completed remote builds in B44921: Diff 104343.Mar 29 2022, 8:47 PM
dchagin updated this revision to Diff 104344.Mar 29 2022, 8:48 PM

whoops, ugly arc:(

Harbormaster completed remote builds in B44922: Diff 104344.Mar 29 2022, 8:48 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.Mar 29 2022, 11:15 PM

I don't see any manual pages in this.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 31 2022, 5:50 PM
Closed by commit rG0c6b1ff7de56: linux(4): Consolidate wait* facility into linux_common_wait(). (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rG0c6b1ff7de56: linux(4): Consolidate wait* facility into linux_common_wait()..
dchagin added a commit: rG721dcd87abe3: linux(4): Consolidate wait* facility into linux_common_wait()..Jun 17 2022, 7:41 PM

Revision Contents
Changeset List

Diff 104343

View Options

lib/libc/sys/getdirentries.2

Loading...
View Options

share/man/man4/linux.4

Loading...
View Options

sys/amd64/linux/linux_proto.h

Loading...
View Options

sys/amd64/linux/linux_sysent.c

Loading...
View Options

sys/amd64/linux/linux_systrace_args.c

Loading...
View Options

sys/amd64/linux/syscalls.master

Loading...
View Options

sys/amd64/linux32/linux.h

Loading...
View Options

sys/amd64/linux32/linux32_proto.h

Loading...
View Options

sys/amd64/linux32/linux32_sysent.c

Loading...
View Options

sys/amd64/linux32/linux32_systrace_args.c

Loading...
View Options

sys/amd64/linux32/linux32_sysvec.c

Loading...
View Options

sys/amd64/linux32/syscalls.master

Loading...
View Options

sys/arm64/linux/linux_proto.h

Loading...
View Options

sys/arm64/linux/linux_sysent.c

Loading...
View Options

sys/arm64/linux/linux_systrace_args.c

Loading...
View Options

sys/arm64/linux/syscalls.master

Loading...
View Options

sys/compat/linprocfs/linprocfs.c

Loading...
View Options

sys/compat/linux/linux_common.h

Loading...
View Options

sys/compat/linux/linux_dummy.c

Loading...
View Options

sys/compat/linux/linux_emul.h

Loading...
View Options

sys/compat/linux/linux_emul.c

Loading...
View Options

sys/compat/linux/linux_file.c

Loading...
View Options

sys/compat/linux/linux_mib.h

Loading...
View Options

sys/compat/linux/linux_misc.h

Loading...
View Options

sys/compat/linux/linux_misc.c

Loading...
View Options

sys/compat/linux/linux_rseq.h

Loading...
View Options

sys/compat/linux/linux_rseq.c

Loading...
View Options

sys/compat/linux/linux_socket.c

Loading...
View Options

sys/compat/linux/linux_stats.c

Loading...
View Options

sys/i386/linux/linux_proto.h

Loading...
View Options

sys/i386/linux/linux_sysent.c

Loading...
View Options

sys/i386/linux/linux_systrace_args.c

Loading...
View Options

sys/i386/linux/syscalls.master

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...
View Options

sys/modules/linux/Makefile

Loading...
View Options

sys/modules/linux64/Makefile

Loading...
View Options

sys/sys/vnode.h

Loading...